public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Darren Hart <dvhltc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Bug: fio traps into kernel without exiting because futex has a deadloop
Date: Thu, 11 Jun 2009 14:05:31 +0800	[thread overview]
Message-ID: <1244700331.2560.271.camel@ymzhang> (raw)
In-Reply-To: <4A309D16.4040505@us.ibm.com>

On Wed, 2009-06-10 at 22:58 -0700, Darren Hart wrote:
> Zhang, Yanmin wrote:
> 
> Hi Zhang,
> 
> > I investigate a fio hang issue. When I run fio multi-process
> > testing on many disks, fio traps into kernel and doesn't exit
> > (mostly hit once after runing sub test cases for hundreds of times).
> > 
> > Oprofile data shows kernel consumes time with some futex functions.
> > Command kill couldn't kill the process and machine reboot also hangs.
> > 
> > Eventually, I locate the root cause as a bug of futex. Kernel enters
> > a deadloop between 'retry' and 'goto retry' in function futex_wake_op.
> > By unknown reason (might be an issue of fio or glibc), parameter uaddr2
> > points to an area which is READONLY. So futex_atomic_op_inuser returns
> > -EFAULT when trying to changing the data at uaddr2, but later get_user
> > still succeeds becasue the area is READONLY. Then go back to retry.
> > 
> > I create a simple test case to trigger it, which just shmat an READONLY
> > area for address uaddr2.
> > 
> > It could be used as a DOS attack.
> 
> Nice work on the diagnosis.  I recall discussing something like this a 
> couple weeks back.  I thought this was fixed with a patch to ensure the 
> pages were writable.  Cc'ing Thomas G. to confirm.  

> I didn't see a 
> kernel version in your report, what are you running?
2.6.30-rc1~rc8.



      reply	other threads:[~2009-06-11  6:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  3:08 Bug: fio traps into kernel without exiting because futex has a deadloop Zhang, Yanmin
2009-06-11  5:55 ` Peter Zijlstra
2009-06-11  6:18   ` Peter Zijlstra
2009-06-11  6:21     ` Darren Hart
2009-06-11  8:33     ` Zhang, Yanmin
2009-06-11  9:36       ` Peter Zijlstra
2009-06-11 11:36       ` Peter Zijlstra
2009-06-12  0:59         ` Zhang, Yanmin
2009-06-12  8:12           ` Thomas Gleixner
2009-06-12  8:39             ` Thomas Gleixner
2009-06-15  6:03               ` Zhang, Yanmin
2009-06-15  7:57                 ` Thomas Gleixner
2009-06-16  3:16                   ` Zhang, Yanmin
2009-06-15  8:27                 ` Thomas Gleixner
2009-06-15  8:27                 ` Peter Zijlstra
2009-06-11  5:58 ` Darren Hart
2009-06-11  6:05   ` Zhang, Yanmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244700331.2560.271.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=dvhltc@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox