From: Marcel Holtmann <marcel@holtmann.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
"David S. Miller" <davem@davemloft.net>,
Stephane Eranian <eranian@googlemail.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] Performance Counters for Linux
Date: Thu, 11 Jun 2009 18:34:58 +0200 [thread overview]
Message-ID: <1244738098.27363.36.camel@violet> (raw)
In-Reply-To: <alpine.LFD.2.01.0906110922080.3573@localhost.localdomain>
Hi Linus,
> > Err, no. This adds tons of userspace code into tools/ which
> > should not be in the kernel tree but a proper package.
>
> I disagree.
>
> We've had tons of cases where we tried to "separate" the user-land code
> and the kernel code, in the name of "beauty" of whatever.
>
> It's almost invariably a disaster.
>
> Look at oprofile. F*ck me, what a horrid piece of crap. It took literally
> months for the user mode tools to catch up and get the patches to support
> new functionality into CVS (or is it SVN?), and after that it took even
> longer for them to become part of a release and be picked up by
> distributions. In fact, I'm not sure it is part of a release even now - I
> had to make a bug report to Fedora to get atom and Nehalem support in my
> tools: I think they took the unofficial patch.
>
> Or look at the crazy things we used to do for X. It's going away (slowly),
> because some of the most incestuous things are actually just being
> integrated into the kernel, and so there's less of the "two broken pieces"
> approach, and more of a "one working piece" kind of thing.
>
> So I'd much rather have kernel tools with the kernel, than have to depend
> on some external entity that doesn't really care.
so do you expect us to merge stuff like ip, iw, rfkill, crda, the WiMAX
tools, the Bluetooth ones and whatever we have that are all have the
same issues to be merged into the kernel source code as well.
I see no reason this can't be maintained properly outside the kernel
source. You will always have bad sheeps and screw-ups, but just putting
everything into one single location is not a good idea either. Other
subsystems do this well and so could Ingo.
Also please consider the distro point of view. All these distros have
already a hard time to keep up with the kernel patches etc. It is a lot
easier to update a userspace package then having to provide a patches
kernel source.
Regards
Marcel
next prev parent reply other threads:[~2009-06-11 16:35 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 16:03 [GIT PULL] Performance Counters for Linux Ingo Molnar
2009-06-11 16:17 ` Christoph Hellwig
2009-06-11 16:26 ` Linus Torvalds
2009-06-11 16:34 ` Marcel Holtmann [this message]
2009-06-11 16:38 ` Linus Torvalds
2009-06-11 16:46 ` Christoph Hellwig
2009-06-11 16:54 ` Linus Torvalds
2009-06-11 16:47 ` Marcel Holtmann
2009-06-11 18:04 ` David Newall
2009-06-11 16:52 ` Al Viro
2009-06-11 16:56 ` Peter Zijlstra
2009-06-11 17:00 ` Christoph Hellwig
2009-06-11 17:05 ` Ray Lee
2009-06-11 17:08 ` Marcel Holtmann
2009-06-11 17:12 ` Al Viro
2009-06-11 17:22 ` Ray Lee
2009-06-11 17:06 ` Linus Torvalds
2009-06-11 17:59 ` Pekka Enberg
2009-06-11 18:10 ` David Newall
2009-06-11 18:21 ` Linus Torvalds
2009-06-11 18:38 ` David Newall
2009-06-11 18:44 ` Linus Torvalds
2009-06-11 19:07 ` David Newall
2009-06-11 19:23 ` Linus Torvalds
2009-06-11 19:29 ` Linus Torvalds
2009-06-11 19:35 ` David Newall
2009-06-11 19:49 ` Linus Torvalds
2009-06-12 1:43 ` Robert Richter
2009-06-12 3:21 ` David Newall
2009-06-11 19:37 ` David Newall
2009-06-11 18:51 ` Christoph Hellwig
2009-06-11 19:05 ` Marcel Holtmann
2009-06-11 18:24 ` Martin Bligh
2009-06-11 18:34 ` Linus Torvalds
2009-06-11 20:23 ` Ingo Molnar
2009-06-11 20:49 ` Marcel Holtmann
2009-06-11 21:08 ` Sam Ravnborg
2009-06-11 21:17 ` Marcel Holtmann
2009-06-11 21:26 ` Sam Ravnborg
2009-06-11 22:18 ` Jiri Slaby
2009-06-11 22:27 ` Linus Torvalds
2009-06-11 22:38 ` Alan Cox
2009-06-11 22:49 ` Linus Torvalds
2009-06-12 7:35 ` Alan Cox
2009-06-11 23:19 ` Al Viro
2009-06-11 23:25 ` Linus Torvalds
2009-06-12 0:26 ` Al Viro
2009-06-12 2:58 ` Linus Torvalds
2009-06-12 4:05 ` Al Viro
2009-06-11 21:59 ` Steven Rostedt
2009-06-12 10:19 ` Jörn Engel
2009-06-11 21:14 ` Ingo Molnar
2009-06-28 1:19 ` Felipe Contreras
2009-06-11 19:58 ` Andrew Morton
2009-06-11 20:09 ` Linus Torvalds
2009-06-12 4:07 ` Kyle McMartin
2009-06-11 16:58 ` Linus Torvalds
2009-06-11 18:50 ` Sam Ravnborg
2009-06-15 13:41 ` Giacomo A. Catenazzi
2009-06-15 15:18 ` Sam Ravnborg
2009-06-12 9:56 ` stephane eranian
2009-06-12 10:28 ` Ingo Molnar
2009-06-18 21:58 ` stephane eranian
2009-06-22 13:10 ` Performance analysis under Linux (was: Re: [GIT PULL] Performance Counters for Linux) Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244738098.27363.36.camel@violet \
--to=marcel@holtmann.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eranian@googlemail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox