From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
Linux-MIPS <linux-mips@linux-mips.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h
Date: Sun, 14 Jun 2009 14:17:46 +0800 [thread overview]
Message-ID: <1244960266.4968.162.camel@falcon> (raw)
In-Reply-To: <84144f020906132259v2637b436vbc42b49c2adf06ff@mail.gmail.com>
On Sun, 2009-06-14 at 08:59 +0300, Pekka Enberg wrote:
> On Sun, Jun 14, 2009 at 8:54 AM, Wu Zhangjin<wuzhangjin@gmail.com> wrote:
> > From: Wu Zhangjin <wuzj@lemote.com>
> >
> > when compiling linux-mips with kmemtrace enabled, this error will be
> > there:
> >
> > include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> > a function)
> >
> > I checked the source code and found trace_seq.h used PAGE_SIZE but not
> > include the relative header file, so, fix it via adding the header file
> > <asm/page.h>
> >
> > this error will not be triggered in linux-x86 for there is a
> > <asm/page.h> header file included in a certain header file. but which
> > not means <asm/page.h> is not needed in trace_seq.h
> >
> > Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
>
> This looks like a generic tracing issue, not a kmemtrace problem so
> the subject line needs fixing. But the change looks good to me:
>
so, what about this subject?
ftrace: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
will add it later.
thanks!
Wu Zhangjin
prev parent reply other threads:[~2009-06-14 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 5:54 [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h Wu Zhangjin
2009-06-14 5:59 ` Pekka Enberg
2009-06-14 6:17 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244960266.4968.162.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=penberg@cs.helsinki.fi \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox