[PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h

[PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h

[Wu Zhangjin]

From: Wu Zhangjin <wuzj@lemote.com>

when compiling linux-mips with kmemtrace enabled, this error will be
there:

include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
				a function)

I checked the source code and found trace_seq.h used PAGE_SIZE but not
include the relative header file, so, fix it via adding the header file
<asm/page.h>

this error will not be triggered in linux-x86 for there is a
<asm/page.h> header file included in a certain header file. but which
not means <asm/page.h> is not needed in trace_seq.h

Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
---
 include/linux/trace_seq.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@
 
 #include <linux/fs.h>
 
+#include <asm/page.h>
+
 /*
  * Trace sequences are used to allow a function to call several other functions
  * to create a string of data to use (up to a max of PAGE_SIZE.
-- 
1.6.0.4

Re: [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h

[Pekka Enberg]

On Sun, Jun 14, 2009 at 8:54 AM, Wu Zhangjin<wuzhangjin@gmail.com> wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
>
> when compiling linux-mips with kmemtrace enabled, this error will be
> there:
>
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
>                                a function)
>
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> include the relative header file, so, fix it via adding the header file
> <asm/page.h>
>
> this error will not be triggered in linux-x86 for there is a
> <asm/page.h> header file included in a certain header file. but which
> not means <asm/page.h> is not needed in trace_seq.h
>
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>

This looks like a generic tracing issue, not a kmemtrace problem so
the subject line needs fixing. But the change looks good to me:

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

Re: [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h

[Wu Zhangjin]

On Sun, 2009-06-14 at 08:59 +0300, Pekka Enberg wrote:
> On Sun, Jun 14, 2009 at 8:54 AM, Wu Zhangjin<wuzhangjin@gmail.com> wrote:
> > From: Wu Zhangjin <wuzj@lemote.com>
> >
> > when compiling linux-mips with kmemtrace enabled, this error will be
> > there:
> >
> > include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> >                                a function)
> >
> > I checked the source code and found trace_seq.h used PAGE_SIZE but not
> > include the relative header file, so, fix it via adding the header file
> > <asm/page.h>
> >
> > this error will not be triggered in linux-x86 for there is a
> > <asm/page.h> header file included in a certain header file. but which
> > not means <asm/page.h> is not needed in trace_seq.h
> >
> > Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
> 
> This looks like a generic tracing issue, not a kmemtrace problem so
> the subject line needs fixing. But the change looks good to me:
> 
so, what about this subject?
	
  ftrace: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h 

> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

will add it later.

thanks!
Wu Zhangjin