From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756088AbZFOWeV (ORCPT ); Mon, 15 Jun 2009 18:34:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751382AbZFOWeN (ORCPT ); Mon, 15 Jun 2009 18:34:13 -0400 Received: from gate.crashing.org ([63.228.1.57]:38364 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbZFOWeM (ORCPT ); Mon, 15 Jun 2009 18:34:12 -0400 Subject: Re: [GIT PULL v2] Early SLAB fixes for 2.6.31 From: Benjamin Herrenschmidt To: Nick Piggin Cc: Pekka Enberg , Heiko Carstens , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, cl@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, lizf@cn.fujitsu.com, mingo@elte.hu, yinghai@kernel.org In-Reply-To: <20090615112827.GC6012@wotan.suse.de> References: <20090615081831.GA5411@osiris.boeblingen.de.ibm.com> <84144f020906150210w7fa29042xc12efb4a087e3d26@mail.gmail.com> <20090615094148.GC1314@wotan.suse.de> <1245059476.12400.7.camel@pasglop> <20090615101254.GB10294@wotan.suse.de> <1245062388.12400.17.camel@pasglop> <20090615112205.GA6012@wotan.suse.de> <20090615112827.GC6012@wotan.suse.de> Content-Type: text/plain Date: Tue, 16 Jun 2009 07:32:47 +1000 Message-Id: <1245101567.12400.38.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-06-15 at 13:28 +0200, Nick Piggin wrote: > If a couple of specialised early boot code places have > to test slab_is_available() to prevent crap leaking into > our main allocators, then that's quite fine by me. slab_is_available() will not fix the problem in that case. In fact, existing tests of slab_is_available() have been broken because they assumed that when it was true, then GFP_KERNEL would work. Ben.