From: Joerg Roedel <joerg.roedel@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Chris Wright <chrisw@sous-sol.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 1/6] amd-iommu: disable IOMMU hardware on shutdown
Date: Tue, 16 Jun 2009 10:56:10 +0200 [thread overview]
Message-ID: <1245142575-7166-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1245142575-7166-1-git-send-email-joerg.roedel@amd.com>
When the IOMMU stays enabled the BIOS may not be able to finish the
machine shutdown properly. So disable the hardware on shutdown.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/include/asm/amd_iommu.h | 2 ++
arch/x86/kernel/amd_iommu_init.c | 5 +++++
arch/x86/kernel/pci-dma.c | 2 ++
3 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/amd_iommu.h b/arch/x86/include/asm/amd_iommu.h
index 262e028..bdf96f1 100644
--- a/arch/x86/include/asm/amd_iommu.h
+++ b/arch/x86/include/asm/amd_iommu.h
@@ -29,9 +29,11 @@ extern void amd_iommu_detect(void);
extern irqreturn_t amd_iommu_int_handler(int irq, void *data);
extern void amd_iommu_flush_all_domains(void);
extern void amd_iommu_flush_all_devices(void);
+extern void amd_iommu_shutdown(void);
#else
static inline int amd_iommu_init(void) { return -ENODEV; }
static inline void amd_iommu_detect(void) { }
+static inline void amd_iommu_shutdown(void) { }
#endif
#endif /* _ASM_X86_AMD_IOMMU_H */
diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 238989e..575ca46 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -1273,6 +1273,11 @@ free:
goto out;
}
+void amd_iommu_shutdown(void)
+{
+ disable_iommus();
+}
+
/****************************************************************************
*
* Early detect code. This code runs at IOMMU detection time in the DMA
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 745579b..328592f 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -290,6 +290,8 @@ static int __init pci_iommu_init(void)
void pci_iommu_shutdown(void)
{
gart_iommu_shutdown();
+
+ amd_iommu_shutdown();
}
/* Must execute after PCI subsystem */
fs_initcall(pci_iommu_init);
--
1.6.3.1
next prev parent reply other threads:[~2009-06-16 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 8:56 [git pull][PATCH 0/6] amd-iommu fixes Joerg Roedel
2009-06-16 8:56 ` Joerg Roedel [this message]
2009-06-16 8:56 ` [PATCH 2/6] x86: disable IOMMUs on kernel crash Joerg Roedel
2009-06-16 8:56 ` [PATCH 3/6] amd-iommu: flush domain tlb when attaching a new device Joerg Roedel
2009-06-16 8:56 ` [PATCH 4/6] amd-iommu: disable cmd buffer and evt logging before reprogramming iommu Joerg Roedel
2009-06-16 8:56 ` [PATCH 5/6] amd-iommu: set event buffer head and tail to 0 manually Joerg Roedel
2009-06-16 8:56 ` [PATCH 6/6] amd-iommu: resume cleanup Joerg Roedel
2009-06-16 9:52 ` [git pull][PATCH 0/6] amd-iommu fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245142575-7166-2-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=chrisw@sous-sol.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox