From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -tip] x86: mm/init_32.c fix style problems
Date: Sun, 21 Jun 2009 16:54:52 +0530 [thread overview]
Message-ID: <1245583492.3052.5.camel@localhost.localdomain> (raw)
Impact: cleanup
Fix :
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
ERROR: do not initialise externals to 0 or NULL
ERROR: code indent should use tabs where possible
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:ExV) X 3
total: 6 errors, 1 warning
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/mm/init_32.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index 3cd7711..64f0ee3 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -30,12 +30,12 @@
#include <linux/memory_hotplug.h>
#include <linux/initrd.h>
#include <linux/cpumask.h>
+#include <linux/uaccess.h>
#include <asm/asm.h>
#include <asm/bios_ebda.h>
#include <asm/processor.h>
#include <asm/system.h>
-#include <asm/uaccess.h>
#include <asm/pgtable.h>
#include <asm/dma.h>
#include <asm/fixmap.h>
@@ -56,7 +56,7 @@ unsigned long highstart_pfn, highend_pfn;
static noinline int do_test_wp_bit(void);
-bool __read_mostly __vmalloc_start_set = false;
+bool __read_mostly __vmalloc_start_set;
static __init void *alloc_low_page(void)
{
@@ -215,7 +215,7 @@ page_table_range_init(unsigned long start, unsigned long end, pgd_t *pgd_base)
for (; (pmd_idx < PTRS_PER_PMD) && (vaddr != end);
pmd++, pmd_idx++) {
pte = page_table_kmap_check(one_page_table_init(pmd),
- pmd, vaddr, pte);
+ pmd, vaddr, pte);
vaddr += PMD_SIZE;
}
@@ -989,12 +989,12 @@ static noinline int do_test_wp_bit(void)
"1: movb %1, %0 \n"
" xorl %2, %2 \n"
"2: \n"
- _ASM_EXTABLE(1b,2b)
- :"=m" (*(char *)fix_to_virt(FIX_WP_TEST)),
+ _ASM_EXTABLE(1b, 2b)
+ : "=m" (*(char *)fix_to_virt(FIX_WP_TEST)),
"=q" (tmp_reg),
"=r" (flag)
- :"2" (1)
- :"memory");
+ : "2" (1)
+ : "memory");
return flag;
}
--
1.6.0.6
next reply other threads:[~2009-06-21 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 11:24 Jaswinder Singh Rajput [this message]
2009-06-21 11:35 ` [PATCH -tip] x86: mm/init_32.c fix style problems Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245583492.3052.5.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox