From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rohit Seth <rohitseth@google.com>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: mm/hugetlbpage.c fix style problems
Date: Sun, 21 Jun 2009 17:09:55 +0530 [thread overview]
Message-ID: <1245584395.3052.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20090621112201.GA13435@elte.hu>
On Sun, 2009-06-21 at 13:22 +0200, Ingo Molnar wrote:
> this change is not an improvement either.
>
> Plus at a first glance that file has a couple of other problems as
> well beyond trivial style issue:
>
> - dead code which should be removed
>
> - a 64-bit only boot option that should probably be extended to
> 32-bit as well
>
> - insanely long function names with local scope, causing ugly
> linebreaks
>
> and more style issues as well:
>
> - various inconsistent capitalizations in comment blocks
>
> - some other small details as well
>
> Lets try to do a genuinely big and comprehensive forward step that
> addresses all these issues (and any other issues that are in that
> file), ok?
>
ok, I will try.
--
JSR
next prev parent reply other threads:[~2009-06-21 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 11:14 [PATCH -tip] x86: mm/hugetlbpage.c fix style problems Jaswinder Singh Rajput
2009-06-21 11:22 ` Ingo Molnar
2009-06-21 11:39 ` Jaswinder Singh Rajput [this message]
2009-06-21 16:20 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245584395.3052.8.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rohitseth@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox