Re: [merged] proctxt-update-kernel-filesystem-proctxt-documentation.patch removed from -mm tree

Stefani Seibold
2009-06-24T15:58:17Z

Am Mittwoch, den 24.06.2009, 08:30 -0700 schrieb Andrew Morton:
> On Wed, 24 Jun 2009 11:33:25 +0200 Stefani Seibold <stefani@seibold.net> wrote:
>
> > > > Alexey's point is that follow_page() will return NULL if it hits a
> > > > swapped-out stack page and the loop will exit, leading to an incorrect
> > > > (ie: short) return value from get_stack_usage_in_bytes().
> > > >
> > > > Is this claim wrong?
> > >
> >
> > No.
> >
> > I digged in the kernel source and the only solution i found is to use
> > the walk_page_range() like show_smap() in proc/fs/task_mmu.c.
> >
> > Maybe there is an easier way, but i dont know.
> >
> > So i would implement a similar function like smaps_pte_range() in
> > proc/fs/task_mmu.c to detected the high water usage.
>
> Perhaps we could enhance follow_page() so that it can tell the caller
> when the target page is "virtually there", but swapped out. Add a new
> FOLL_SWAP, I guess.
>

I currently fixed it by using walk_page_range(). I think this is a quiet
good solution. But if you like i can do it in a future version.

> How to communicate this back to the caller? Perhaps add another
> argument to follow_page(), perhaps return some magic value such as
>
> #define FOLLOW_PAGE_SWAPPED_PAGE ((struct page *)1)
>
> Adding the additional argument would be nicer.

IMHO i think it would be the best to add a new FOLL_NOTIFY_SWAP flag and
if the page is swapped out return the FOLLOW_PAGE_SWAPPED_PAGE magic if
this flag is passed.