From: David Woodhouse <dwmw2@infradead.org>
To: vimal singh <vimalsingh@ti.com>
Cc: "tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david-b@pacbell.net" <david-b@pacbell.net>
Subject: Re: [PATCH][MTD][NAND]: fix omap2.c compile failure and warning
Date: Sat, 27 Jun 2009 08:45:59 +0100 [thread overview]
Message-ID: <1246088759.663.106.camel@macbook.infradead.org> (raw)
In-Reply-To: <63536.192.168.10.89.1246081026.squirrel@dbdmail.itg.ti.com>
On Sat, 2009-06-27 at 11:07 +0530, vimal singh wrote:
> > The 'status' you return in the case that you _have_ gone through the
> > loop is still wrong though, isn't it?
> Yes, I have corrected that in below patch. Its my bad, I did not fix it
> previously.
>
> Signed-off-by: Vimal Singh <vimalsingh at ti.com>
> Signed-off-by: Ming Lei <tom.leiming at gmail.com>
Er, did he? And please put proper email addresses in. If you can't find
an @ sign on your keyboard, cut and paste it from elsewhere.
> @@ -558,6 +560,7 @@ static int omap_wait(struct mtd_info *mtd, struct nand_chip
> status = __raw_readb(this->IO_ADDR_R);
> - if (!(status & 0x40))
> + if (status & NAND_STATUS_READY)
> break;
Hm... now you're polling the PASS/FAIL bit in the status, not the
READY/BUSY bit. I suspect that's not going to work too well...
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-06-27 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53729.192.168.10.89.1246035472.squirrel@dbdmail.itg.ti.com>
2009-06-26 17:02 ` [PATCH][MTD][NAND]: fix omap2.c compile failure and warning vimal singh
2009-06-26 17:14 ` David Woodhouse
[not found] ` <57946.192.168.10.89.1246035774.squirrel@dbdmail.itg.ti.com>
2009-06-27 5:37 ` vimal singh
2009-06-27 7:45 ` David Woodhouse [this message]
2009-06-28 5:40 vimal singh
-- strict thread matches above, loose matches on Subject: below --
2009-06-26 13:21 tom.leiming
2009-06-26 15:09 ` David Woodhouse
2009-06-26 15:45 ` Singh, Vimal
2009-06-26 16:18 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246088759.663.106.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tom.leiming@gmail.com \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox