Re: [git pull] drm: previous pull req + 1.

Maxim Levitsky
2009-06-22T18:09:43Z

On Sun, 2009-06-21 at 22:24 +0100, Chris Wilson wrote:
> On Sun, 2009-06-21 at 17:47 +0300, Maxim Levitsky wrote:
> > > 52dc7d32b88156248167864f77a9026abe27b432 is first bad commit
> > > commit 52dc7d32b88156248167864f77a9026abe27b432
> > > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > > Date: Sat Jun 6 09:46:01 2009 +0100
>
> The error here seems to be my presumption that only the i915 was using
> fences for GPU access. (In hindsight, it seems obvious that we do not
> know why the fence was allocated for the object and so if it has
> outstanding rendering, we must assume that it is using a fence for a
> rendering op.)
>
> To confirm, please can you try:
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c
> b/drivers/gpu/drm/i915/i915_gem.c
> index fd2b8bd..0735518 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2347,7 +2347,7 @@ i915_gem_object_put_fence_reg(struct
> drm_gem_object *obj)
> * therefore we must wait for any outstanding access to complete
> * before clearing the fence.
> */
> - if (!IS_I965G(dev)) {
> + if (1) {
> int ret;
>
> i915_gem_object_flush_gpu_write_domain(obj);

Nope, same thing.

I use commit 87ef92092fd092936535ba057ee19b97bb6a709a + this patch
Note that GE doesn't hang the system when maximizing it.

It is for sure tiled textures accessed incorrectly, same behavior
observed in many games (they still run though)

Best regards,
Maxim Levitsky