public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sheng Yang <sheng@linux.intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH v2] enable x2APIC without interrupt remapping under KVM
Date: Mon, 29 Jun 2009 03:46:56 -0700	[thread overview]
Message-ID: <1246272416.27006.10632.camel@localhost.localdomain> (raw)
In-Reply-To: <20090629100837.GW20289@redhat.com>

On Mon, 2009-06-29 at 03:08 -0700, Gleb Natapov wrote:
>  
> -	local_irq_save(flags);
>  	mask_IO_APIC_setup(ioapic_entries);
> -	mask_8259A();

Is there a reason why the 8259 mask/unmask operations are separated from
io-apic mask/unmask operations.

Can we keep it together so that it will be easy to read and understand
that we first do the interrupt subsystem mask, try enabling IR and
x2apic and  unmask the interrupt subsystem.

Otherwise I am ok with this change.

thanks,
suresh


  parent reply	other threads:[~2009-06-29 10:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29 10:08 [PATCH v2] enable x2APIC without interrupt remapping under KVM Gleb Natapov
2009-06-29 10:22 ` Ingo Molnar
2009-06-29 10:33   ` Gleb Natapov
2009-06-29 10:46 ` Suresh Siddha [this message]
2009-06-29 11:25   ` Gleb Natapov
2009-06-29 11:48     ` Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246272416.27006.10632.camel@localhost.localdomain \
    --to=suresh.b.siddha@intel.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox