From: "alex.shi" <alex.shi@intel.com>
To: Yinghai@kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chen, Tim C" <tim.c.chen@intel.com>,
"Zhang, Yanmin" <yanmin.zhang@intel.com>
Subject: [patch] fix hugepage unuseable issu on non-NUMA machine
Date: Mon, 29 Jun 2009 19:10:02 +0800 [thread overview]
Message-ID: <1246273802.3160.28.camel@alexs-hp> (raw)
73d60b7f747176dbdff826c4127d22e1fd3f9f74 commit introduced a nodes_clear
function for NUMA machine. But seems the commit omits non-NUMA machine.
If find_zone_movable_pfns_for_nodes/early_calculate_totalpages has no
chance to run. nodes_clear will block HUPEPAGE using in my specjbb2005
testing.
So maybe we need to disable nodes_clear sometimes. With the following
patch. specjbb2005 recovered.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5d714f8..46ff861 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4246,7 +4246,8 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
* find_zone_movable_pfns_for_nodes/early_calculate_totalpages init
* that node_mask, clear it at first
*/
- nodes_clear(node_states[N_HIGH_MEMORY]);
+ if (required_kernelcore)
+ nodes_clear(node_states[N_HIGH_MEMORY]);
/* Initialise every node */
mminit_verify_pageflags_layout();
setup_nr_node_ids();
next reply other threads:[~2009-06-29 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 11:10 alex.shi [this message]
2009-06-29 17:01 ` [patch] fix hugepage unuseable issu on non-NUMA machine Yinghai Lu
2009-07-01 9:38 ` Alex Shi
2009-07-01 18:12 ` Yinghai Lu
2009-07-02 2:05 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246273802.3160.28.camel@alexs-hp \
--to=alex.shi@intel.com \
--cc=Yinghai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox