Re: [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation

Alexander van Heukelum
2009-06-30T11:42:26Z

Hi Mike,

I agree with the code, but I do have a remark...

The ENTRY() macro already includes the ALIGN, so you could get
rid of the preceding ALIGN. But it's just a neatness thing, because
two consecutive ALIGNS don't change the resulting binary.

At any rate:

Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>

(maybe the x86-committer feels comfortable enough to remove the ALIGN ;)
)

On Tue, 30 Jun 2009 12:54:00 +0200, "Mike Galbraith" <efault@gmx.de>
said:
> x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Alexander van Heukelum <heukelum@mailshack.com>
> Cc: Cyrill Gorcunov <gorcunov@gmail.com>
> LKML-Reference: <new-submission>
>
> ---
> arch/x86/lib/clear_page_64.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/arch/x86/lib/clear_page_64.S
> ===================================================================
> --- linux-2.6.orig/arch/x86/lib/clear_page_64.S
> +++ linux-2.6/arch/x86/lib/clear_page_64.S
> @@ -6,14 +6,14 @@
> * rdi page
> */
> ALIGN
> -clear_page_c:
> +ENTRY(clear_page_c)
> CFI_STARTPROC
> movl $4096/8,%ecx
> xorl %eax,%eax
> rep stosq
> ret
> CFI_ENDPROC
> -ENDPROC(clear_page)
> +ENDPROC(clear_page_c)
>
> ENTRY(clear_page)
> CFI_STARTPROC
>
>