From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755819AbZGAFcn (ORCPT ); Wed, 1 Jul 2009 01:32:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752064AbZGAFce (ORCPT ); Wed, 1 Jul 2009 01:32:34 -0400 Received: from mga06.intel.com ([134.134.136.21]:46676 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751003AbZGAFcd (ORCPT ); Wed, 1 Jul 2009 01:32:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.42,321,1243839600"; d="scan'208";a="529269341" Subject: Re: ffsb create_4k 16% regression From: "Zhang, Yanmin" To: Andrew Morton Cc: Al Viro , LKML , Jan Kara In-Reply-To: <1246262818.2560.443.camel@ymzhang> References: <1246262818.2560.443.camel@ymzhang> Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Jul 2009 13:33:00 +0800 Message-Id: <1246426380.2560.473.camel@ymzhang> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-06-29 at 16:06 +0800, Zhang, Yanmin wrote: > I run many ffsb test cases on JBODs (typically 13/12 disks). Comparing > with kernel 2.6.30, 2.6.31-rc1 has about 16% regression with > ffsb_create_4k. The sub test case creates files continuously for 10 > minitues and every file is 1MB. > > Bisect located below patch. > > > 5cee5815d1564bbbd505fea86f4550f1efdb5cd0 is first bad commit > commit 5cee5815d1564bbbd505fea86f4550f1efdb5cd0 > Author: Jan Kara > Date: Mon Apr 27 16:43:51 2009 +0200 > > vfs: Make sys_sync() use fsync_super() (version 4) > > It is unnecessarily fragile to have two places (fsync_super() and do_sync()) > doing data integrity sync of the filesystem. Alter __fsync_super() to > accommodate needs of both callers and use it. So after this patch > __fsync_super() is the only place where we gather all the calls needed to > properly send all data on a filesystem to disk. > > > As a matter of fact, ffsb calls sys_sync in the end to make sure all data is > flushed to disks and the flushing is counted into the result. vmstat shows > ffsb is blocked when syncing for a long time. With 2.6.30, ffsb is blocked for > a short time. > > I checked the patch and did experiments to recover the original methods. Eventually, > the root cause is the patch deletes the calling to wakeup_pdflush when syncing, so > only ffsb is blocked on disk I/O. wakeup_pdflush could ask pdflush to write back pages > with ffsb at the same time. > > Below patch against 2.6.31-rc1 fixes it. > > Signed-off-by: Zhang Yanmin > > --- > > --- linux-2.6.31-rc1/fs/sync.c 2009-06-29 12:18:03.000000000 +0800 > +++ linux-2.6.31-rc1_sync/fs/sync.c 2009-06-29 14:56:49.000000000 +0800 > @@ -114,6 +114,7 @@ restart: > > SYSCALL_DEFINE0(sync) > { > + wakeup_pdflush(0); > sync_filesystems(0); > sync_filesystems(1); > if (unlikely(laptop_mode)) Andrew, Would you like to consider the patch for mm tree? Thanks, Yanmin