From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbZGAN5D (ORCPT ); Wed, 1 Jul 2009 09:57:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752342AbZGAN4w (ORCPT ); Wed, 1 Jul 2009 09:56:52 -0400 Received: from hera.kernel.org ([140.211.167.34]:43131 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbZGAN4w (ORCPT ); Wed, 1 Jul 2009 09:56:52 -0400 Subject: Re: [PATCH -tip RESEND] x86: ptrace.c ptrace_get_debugreg() should be static From: Jaswinder Singh Rajput To: Ingo Molnar Cc: Steven Rostedt , x86 maintainers , LKML In-Reply-To: <1246450561.6940.5.camel@hpdv5.satnam> References: <1246450561.6940.5.camel@hpdv5.satnam> Content-Type: text/plain Date: Wed, 01 Jul 2009 19:26:17 +0530 Message-Id: <1246456577.6940.15.camel@hpdv5.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-07-01 at 17:46 +0530, Jaswinder Singh Rajput wrote: > ptrace_get_debugreg() is used only by the same file, so it should be static. > > Also fixed sparse warning : > > CHECK arch/x86/kernel/ptrace.c > arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static? > > Signed-off-by: Jaswinder Singh Rajput > --- Please apply this : [PATCH] x86: ptrace ptrace_get_debugreg() should be static This sparse warning: arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static? triggers because ptrace_get_debugreg() is global but is only used in a single .c file. change ptrace_get_debugreg() to static to fix that - this also address the sparse warning. Signed-off-by: Jaswinder Singh Rajput --- arch/x86/kernel/ptrace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index b457f78..cabdabc 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -557,7 +557,7 @@ restore: /* * Handle PTRACE_PEEKUSR calls for the debug register area. */ -unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n) +static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n) { struct thread_struct *thread = &(tsk->thread); unsigned long val = 0; -- 1.6.0.6