public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Arnaldo Carvalho de Melo" <acme@redhat.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: Re: [patch 0/4] perf_counter tools: support annotation of live kernel modules
Date: Fri, 03 Jul 2009 10:00:58 +0200	[thread overview]
Message-ID: <1246608058.6257.25.camel@marge.simson.net> (raw)
In-Reply-To: <20090703072941.GC7943@elte.hu>

On Fri, 2009-07-03 at 09:29 +0200, Ingo Molnar wrote:
> * Mike Galbraith <efault@gmx.de> wrote:
> 
> > On Thu, 2009-07-02 at 09:17 +0200, Mike Galbraith wrote:
> > 
> > > After I resurrect (well, try) live annotation in top...
> > 
> > Random thought wrt live top annotation: instead of resurrecting in 
> > the previous form, which could be a bit intrusive display space 
> > wise, what do you think of this idea?
> > 
> > Provide a kbd input snapshot trigger which builds a perf record 
> > (hard?) compatible file for the symbols being displayed.  Start a 
> > background task to annotate the lot, stuffing annotate output into 
> > an output file.
> > 
> > Better ideas highly welcome.
> 
> Hm, is there really a performance problem?

Sort of..

> We need to calculate and cache the objdump annotation output once, 
> but after that it should be pretty fast as we just display updated 
> counts with the same lines over and over again. No repeated objdump 
> runs are needed.

But active files follow symbols, which change on the fly.

Besides, as mentioned previously, while displayed annotation was very
cool, it took a lot of display space.  For me, top with the ability to
emit bic-disposable mini-reports would be my primary perf tools usage.
I'd only use big brothers when I needed their power/detail.

	-Mike


  reply	other threads:[~2009-07-03  8:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02  6:03 [patch 0/4] perf_counter tools: support annotation of live kernel modules Mike Galbraith
2009-07-02  6:05 ` [patch 1/4] perf_counter tools: Make symbol loading consistently return number of loaded symbols Mike Galbraith
2009-07-02  7:06   ` [tip:perfcounters/urgent] " tip-bot for Mike Galbraith
2009-07-02  6:07 ` [patch 2/4] perf_counter tools: Add infrastructure to support loading of kernel module symbols Mike Galbraith
2009-07-02  7:06   ` [tip:perfcounters/urgent] " tip-bot for Mike Galbraith
2009-07-02  6:08 ` [patch 3/4] perf_counter tools: connect module support infrastructure to symbol loading infrastructure Mike Galbraith
2009-07-02  7:06   ` [tip:perfcounters/urgent] perf_counter tools: Connect " tip-bot for Mike Galbraith
2009-07-02  6:09 ` [patch 4/4] perf_counter tools: Enable kernel module symbol loading in tools Mike Galbraith
2009-07-02  7:07   ` [tip:perfcounters/urgent] " tip-bot for Mike Galbraith
2009-07-02  6:47 ` [patch 0/4] perf_counter tools: support annotation of live kernel modules Ingo Molnar
2009-07-02  7:17   ` Mike Galbraith
2009-07-02  7:42     ` Ingo Molnar
2009-07-02  7:55       ` Mike Galbraith
2009-07-03  7:27         ` Ingo Molnar
2009-07-03  7:36           ` Mike Galbraith
2009-07-02  8:42     ` Mike Galbraith
2009-07-02  8:53       ` Mike Galbraith
2009-07-03  7:29       ` Ingo Molnar
2009-07-03  8:00         ` Mike Galbraith [this message]
2009-07-03  8:15           ` Ingo Molnar
2009-07-03  8:28             ` Mike Galbraith
2009-07-03  8:53               ` Frederic Weisbecker
2009-07-02 12:10     ` Peter Zijlstra
2009-07-03  7:17       ` Mike Galbraith
2009-07-03  7:24         ` Ingo Molnar
2009-07-03  7:31           ` Jaswinder Singh Rajput
2009-07-03  8:41         ` Frederic Weisbecker
2009-07-03  8:53           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246608058.6257.25.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox