From: Peter Zijlstra <peterz@infradead.org>
To: Mitchell Erblich <erblichs@earthlink.net>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: CFS Scheduler : Period : for NCPUs : Code Suggestion Change
Date: Mon, 06 Jul 2009 14:46:20 +0200 [thread overview]
Message-ID: <1246884380.8143.12.camel@twins> (raw)
In-Reply-To: <B99DC9EB-9502-4E31-B829-6EB7EFC6212C@earthlink.net>
On Tue, 2009-06-30 at 18:36 -0700, Mitchell Erblich wrote:
> This is NOT A PATCH.
>
> PLEASE include my email in the reply as I am not currently on
> the linux kernel mail alias.
>
> This code snap is grabbed from what is believed to be a semi-current
> OS source (fxr.watson.org) comparison webpage.
>
> Upon a quick CFS scheduler code walk, increasing the period
> should ALSO be dependent on the number of online/active CPUs.
>
> The period should be adjusted based on the number of
> online CPUs. This change allows NCPUs * tasks without
> changing/increasing the period.
>
> On first thought NR_CPUS should give the number of cpu on
> the system, however, this may be different from the number of
> CPUs online, thus..
>
> Change #1: place after line 425
> int cpu, ncpu;
>
>
> Change #2: place before line 427
> for_each_online_cpu(cpu) {
> ncpu++;
> }
> nr_running /= ncpu;
>
Ah, but the nr_running number used is _per_ cpu already, so would that
address your concern?
prev parent reply other threads:[~2009-07-06 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 1:36 CFS Scheduler : Period : for NCPUs : Code Suggestion Change Mitchell Erblich
2009-07-06 12:46 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246884380.8143.12.camel@twins \
--to=peterz@infradead.org \
--cc=erblichs@earthlink.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox