* [PATCH] vmalloc.c: fix vmap_page_range() return
@ 2009-07-07 10:00 Figo.zhang
2009-07-07 16:19 ` Figo.zhang
0 siblings, 1 reply; 2+ messages in thread
From: Figo.zhang @ 2009-07-07 10:00 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: lkml
vmap_page_range() would never return a positive number.
Signed-off-by: Figo.zhang <figo1802@gmail.com>
---
mm/vmalloc.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index f8189a4..bbd312d 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1109,10 +1109,6 @@ int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
int err;
err = vmap_page_range(addr, end, prot, *pages);
- if (err > 0) {
- *pages += err;
- err = 0;
- }
return err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vmalloc.c: fix vmap_page_range() return
2009-07-07 10:00 [PATCH] vmalloc.c: fix vmap_page_range() return Figo.zhang
@ 2009-07-07 16:19 ` Figo.zhang
0 siblings, 0 replies; 2+ messages in thread
From: Figo.zhang @ 2009-07-07 16:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, lkml
On Tue, 2009-07-07 at 18:00 +0800, Figo.zhang wrote:
> vmap_page_range() would never return a positive number.
hmm, it is my mistake. vmap_pud_range() will return the succeed mapped
page number.
Best,
Figo.zhang
>
> Signed-off-by: Figo.zhang <figo1802@gmail.com>
> ---
> mm/vmalloc.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index f8189a4..bbd312d 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1109,10 +1109,6 @@ int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
> int err;
>
> err = vmap_page_range(addr, end, prot, *pages);
> - if (err > 0) {
> - *pages += err;
> - err = 0;
> - }
>
> return err;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-07 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-07 10:00 [PATCH] vmalloc.c: fix vmap_page_range() return Figo.zhang
2009-07-07 16:19 ` Figo.zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox