From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: trivial <trivial@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Randy Dunlap <randy.dunlap@oracle.com>,
Tony Luck <tony.luck@intel.com>,
benh@kernel.crashing.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
mchehab@infradead.org, jbarnes@virtuousgeek.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Greg Ungerer <gerg@snapgear.com>, Greg KH <greg@kroah.com>,
David Woodhouse <dwmw2@infradead.org>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Ingo Molnar <mingo@elte.hu>,
tytso@mit.edu, sct@redhat.com, Gadiyar Anand <gadiyar@ti.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo"
Date: Tue, 07 Jul 2009 22:16:39 +0530 [thread overview]
Message-ID: <1246985199.3613.50.camel@ht.satnam> (raw)
In-Reply-To: <16756.1246981440@redhat.com>
Hello David,
On Tue, 2009-07-07 at 16:44 +0100, David Howells wrote:
> Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> > Jaswinder Singh Rajput (22):
> > trivial: fix typo "has has" in multiple files
> > trivial: fix typo "on on" in multiple files
> > trivial: fix typo "that that" in multiple files
>
> NAK. You can't just mechanically reduce the above pairs of words to a single
> instance unconditionally.
>
> "has has" should perhaps be "has had" in some cases.
>
> In "on on", the first preposition may be part of a compound verb (eg: "to go
> on").
>
> In "that that", the second "that" may be specifying the object in relation to
> a previous part of the text.
>
Thanks for your feed-back.
I removed all the patches pointed by you and also removed some more
patches which can create confusion.
Please check new pull request, and let me know if you found some more
issues :
[GIT PULL] V2 trivial fixes typo "foo foo"
Thanks,
--
JSR
next prev parent reply other threads:[~2009-07-07 16:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 14:03 [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo" Jaswinder Singh Rajput
2009-07-07 14:05 ` [PATCH 1/22] trivial: fix typo "a a" in multiple files Jaswinder Singh Rajput
2009-07-07 14:06 ` [PATCH 2/22] trivial: fix typo "and and" " Jaswinder Singh Rajput
2009-07-07 14:08 ` [PATCH 3/22] trivial: fix typo "are are" " Jaswinder Singh Rajput
2009-07-07 14:09 ` [PATCH 4/22] trivial: fix typo "as as" " Jaswinder Singh Rajput
2009-07-07 14:10 ` [PATCH 5/22] trivial: fix typo "be be" " Jaswinder Singh Rajput
2009-07-07 14:11 ` [PATCH 6/22] trivial: fix typo "bit bit" " Jaswinder Singh Rajput
2009-07-07 14:12 ` [PATCH 7/22] trivial: fix typo "by by" " Jaswinder Singh Rajput
2009-07-07 14:13 ` [PATCH 8/22] trivial: fix typo "can can" Jaswinder Singh Rajput
2009-07-07 14:15 ` [PATCH 9/22] trivial: fix typo "could could" in multiple files Jaswinder Singh Rajput
2009-07-07 14:16 ` [PATCH 10/22] trivial: fix typo "from from" " Jaswinder Singh Rajput
2009-07-07 14:17 ` [PATCH 11/22] trivial: fix typo "has has" " Jaswinder Singh Rajput
2009-07-07 15:27 ` David Howells
2009-07-07 14:18 ` [PATCH 12/22] trivial: fix typo "lock lock" Jaswinder Singh Rajput
2009-07-07 14:19 ` [PATCH 13/22] trivial: fix typo "on on" in multiple files Jaswinder Singh Rajput
2009-07-07 15:29 ` David Howells
2009-07-07 14:20 ` [PATCH 14/22] trivial: fix typo "should should" " Jaswinder Singh Rajput
2009-07-07 14:21 ` [PATCH 15/22] trivial: fix typo "test test" Jaswinder Singh Rajput
2009-07-07 14:22 ` [PATCH 16/22] trivial: fix typo "that that" in multiple files Jaswinder Singh Rajput
2009-07-07 15:37 ` David Howells
2009-07-07 16:33 ` Paul E. McKenney
2009-07-07 17:17 ` David Howells
2009-07-07 16:30 ` Paul E. McKenney
2009-07-07 16:49 ` Jaswinder Singh Rajput
2009-07-07 14:23 ` [PATCH 17/22] trivial: fix typo "this this" " Jaswinder Singh Rajput
2009-07-07 14:24 ` [PATCH 18/22] trivial: fix typo "too too" Jaswinder Singh Rajput
2009-07-07 14:24 ` [PATCH 19/22] trivial: fix typo "was was" in multiple files Jaswinder Singh Rajput
2009-07-07 14:25 ` [PATCH 20/22] trivial: fix typo "we we" " Jaswinder Singh Rajput
2009-07-07 14:26 ` [PATCH 21/22] trivial: fix typo "with with" " Jaswinder Singh Rajput
2009-07-07 14:26 ` [PATCH 22/22] trivial: fix typo "you you" Jaswinder Singh Rajput
2009-07-07 15:44 ` [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo" David Howells
2009-07-07 16:11 ` Jesse Barnes
2009-07-07 22:15 ` Jiri Kosina
2009-07-08 4:18 ` Jaswinder Singh Rajput
2009-07-08 8:40 ` David Howells
2009-07-07 16:46 ` Jaswinder Singh Rajput [this message]
2009-07-07 16:30 ` [GIT PULL] V2 " Jaswinder Singh Rajput
2009-07-10 3:11 ` Jaswinder Singh Rajput
2009-07-10 8:42 ` Jiri Kosina
2009-07-10 8:49 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246985199.3613.50.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andreas.herrmann3@amd.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gadiyar@ti.com \
--cc=gerg@snapgear.com \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sct@redhat.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox