From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: avorontsov@ru.mvista.com
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*()
Date: Wed, 08 Jul 2009 14:12:25 +0200 [thread overview]
Message-ID: <1247055145.9777.52.camel@twins> (raw)
In-Reply-To: <20090708120302.GA6341@oksana.dev.rtsoft.ru>
On Wed, 2009-07-08 at 16:03 +0400, Anton Vorontsov wrote:
> On Wed, Jul 08, 2009 at 08:24:23AM +0200, Peter Zijlstra wrote:
> > On Wed, 2009-07-08 at 02:50 +0200, Oleg Nesterov wrote:
> >
> > > /*
> > > * It is valid to assume CPU-locality during early bootup:
> > > */
> > > if (system_state != SYSTEM_RUNNING)
> > > goto out;
> > >
> > > this doesn't look right, smp_init() is called before we set
> > > SYSTEM_RUNNING.
> >
> > The thing is, there's also ton's of code that might end up calling
> > cond_resched() and co before the scheduler is fully initialized.
>
> Hm. Speaking of cond_resched*() only, then it should be pretty
> safe to convert the SYSTEM_RUNNING checks to scheduler_running,
> no? scheduler_running is set after sched_init().
Hmm, that might work, I'd have to audit sched_init_smp() as it seems to
do way too much...
next prev parent reply other threads:[~2009-07-08 12:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 23:58 [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*() Anton Vorontsov
2009-07-08 0:50 ` Oleg Nesterov
2009-07-08 6:24 ` Peter Zijlstra
2009-07-08 12:03 ` Anton Vorontsov
2009-07-08 12:12 ` Peter Zijlstra [this message]
2009-07-08 12:55 ` Anton Vorontsov
2009-07-08 12:58 ` Peter Zijlstra
2009-07-08 20:45 ` [PATCH] sched: Make cond_resched*() available earlier Anton Vorontsov
2009-07-08 16:12 ` [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*() Linus Torvalds
2009-07-08 21:10 ` Andrew Morton
2009-07-08 21:33 ` Anton Vorontsov
2009-07-08 21:47 ` Andrew Morton
2009-07-08 22:20 ` [PATCH] netpoll: Fix carrier detection for drivers that are using phylib Anton Vorontsov
2009-07-09 0:01 ` Linus Torvalds
2009-07-09 3:08 ` David Miller
2009-07-09 7:56 ` Peter Zijlstra
2009-07-09 12:56 ` Matt Mackall
2009-07-09 13:26 ` Matt Mackall
2009-07-09 13:46 ` Peter Zijlstra
2009-07-09 14:18 ` Matt Mackall
2009-07-09 14:31 ` Peter Zijlstra
2009-07-09 14:43 ` Matt Mackall
2009-07-09 14:51 ` Peter Zijlstra
2009-07-09 15:06 ` Matt Mackall
2009-07-09 17:29 ` Linus Torvalds
2009-07-09 12:52 ` Matt Mackall
2009-07-09 23:20 ` [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*() Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247055145.9777.52.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox