From: Peter Zijlstra <peterz@infradead.org>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: possible migration bug with hotplug cpu
Date: Thu, 09 Jul 2009 15:15:52 +0200 [thread overview]
Message-ID: <1247145352.8019.5.camel@twins> (raw)
In-Reply-To: <193b0f820907090555j30106a1cx6e0fffd0c2a19691@mail.gmail.com>
On Thu, 2009-07-09 at 14:55 +0200, Lucas De Marchi wrote:
> On Thu, Jul 9, 2009 at 14:24, Peter Zijlstra<peterz@infradead.org> wrote:
> > One of the things I have wanted to do for a long time is to rename
> > sched_entity to sched_fair_entity, and do something like:
> >
> > struct sched_entity {
> > struct sched_common_entity common;
> >
> > union {
> > struct sched_fair_entity fair;
> > struct sched_rt_entity rt;
> > };
> > };
> >
> > I imagine we can add struct sched_statistics to the end of this as well.
> >
> > The reason I haven't come around to doing this is that it takes a bit of
> > time to refactor the code and find all the common bits. So its been on
> > my todo list like forever.
> >
> > Can I persuade you to look at this? :-)
>
> It looks like a very good idea. As you told, it will take a time to refactor
> the code. I can look at this, but only on the end of next week.
Sure no hurry, its been without that for like forever, so a few more
weeks won't harm anybody, thanks!
> > I'll queue the below, can I add:
> >
> > Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
> >
> > ?
>
> Sure. I'm not very habituated yet with it... do I re-send the email
> or you add it by yourself?
I've added it, simply remember to add that for future patches :-)
next prev parent reply other threads:[~2009-07-09 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 15:48 possible migration bug with hotplug cpu Lucas De Marchi
2009-07-08 15:55 ` Peter Zijlstra
2009-07-08 16:05 ` Lucas De Marchi
2009-07-08 16:39 ` Lucas De Marchi
2009-07-09 11:57 ` Lucas De Marchi
2009-07-09 12:24 ` Peter Zijlstra
2009-07-09 12:55 ` Lucas De Marchi
2009-07-09 13:15 ` Peter Zijlstra [this message]
2009-07-10 10:41 ` [tip:sched/urgent] sched: Reset sched stats on fork() tip-bot for Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247145352.8019.5.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox