From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
linux-kernel@vger.kernel.org, davej@redhat.com,
cpufreq@vger.kernel.org
Subject: Re: [PATCH][cpufreq][Powernow-k8] support family 0xf with 2 low p-states
Date: Fri, 10 Jul 2009 12:05:12 +0200 [thread overview]
Message-ID: <1247220312.7529.24.camel@twins> (raw)
In-Reply-To: <20090702141543.e6d8c0cd.akpm@linux-foundation.org>
On Thu, 2009-07-02 at 14:15 -0700, Andrew Morton wrote:
> On Sun, 26 Jul 2009 10:55:25 -0500
> Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> >
> > Subject: [PATCH][cpufreq][Powernow-k8] support family 0xf with 2 low p-states
>
> Please leave the subsystem identification text outside the [].
> Documentation/SubmittingPatches section 15 has details.
>
>
> > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> > @@ -215,7 +215,8 @@ struct pst_s {
> >
> > #define dprintk(msg...) cpufreq_debug_printk(CPUFREQ_DEBUG_DRIVER, "powernow-k8", msg)
> >
> > -static int core_voltage_pre_transition(struct powernow_k8_data *data, u32 reqvid);
> > +static int core_voltage_pre_transition(struct powernow_k8_data *data,
> > + u32 reqvid, u32 regfid);
> > static int core_voltage_post_transition(struct powernow_k8_data *data, u32 reqvid);
> > static int core_frequency_transition(struct powernow_k8_data *data, u32 reqfid);
>
> It's fairly dopey to have static function declarations in a header file
> - no other .c fail can _use_ them, so they may as well be tucked away
hehe, FAIL, hehe ;-)
> inside their .c file. And that's only needed if the functions indeed
> need to be forward-declared.
prev parent reply other threads:[~2009-07-10 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-26 15:55 [PATCH][cpufreq][Powernow-k8] support family 0xf with 2 low p-states Mark Langsdorf
2009-07-02 21:15 ` Andrew Morton
2009-07-10 10:05 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247220312.7529.24.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox