From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 2/2] sched: Move the sleeping while atomic checks early in cond_resched()
Date: Fri, 10 Jul 2009 16:49:51 +0200 [thread overview]
Message-ID: <1247237391-5352-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1247237391-5352-1-git-send-email-fweisbec@gmail.com>
might_sleep() is called lately in cond_resched(), after the
need_resched()/preempt enabled/system running tests are checked.
It's better to check the sleeps while atomic earlier and not depend
on some environment datas that reduce the chances to detect a
problem.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
include/linux/sched.h | 2 ++
kernel/sched.c | 3 ---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 0cb0d8d..e357dc7 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2279,11 +2279,13 @@ extern int _cond_resched(void);
#ifdef CONFIG_PREEMPT_BKL
static inline int cond_resched(void)
{
+ might_sleep();
return 0;
}
#else
static inline int cond_resched(void)
{
+ might_sleep();
return _cond_resched();
}
#endif
diff --git a/kernel/sched.c b/kernel/sched.c
index 87ecac1..c22804b 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6605,9 +6605,6 @@ SYSCALL_DEFINE0(sched_yield)
static void __cond_resched(void)
{
-#ifdef CONFIG_DEBUG_SPINLOCK_SLEEP
- __might_sleep(__FILE__, __LINE__);
-#endif
/*
* The BKS might be reacquired before we have dropped
* PREEMPT_ACTIVE, which could trigger a second
--
1.6.2.3
next prev parent reply other threads:[~2009-07-10 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 14:49 [PATCH 1/2] sched: Drop the need_resched() loop from cond_resched() Frederic Weisbecker
2009-07-10 14:49 ` Frederic Weisbecker [this message]
2009-07-10 14:59 ` [PATCH 2/2] sched: Move the sleeping while atomic checks early in cond_resched() Peter Zijlstra
2009-07-10 15:08 ` Frederic Weisbecker
2009-07-10 15:12 ` Peter Zijlstra
2009-07-10 16:10 ` Ingo Molnar
2009-07-10 17:14 ` [PATCH] " Frederic Weisbecker
2009-07-10 17:43 ` Peter Zijlstra
2009-07-10 18:08 ` Frederic Weisbecker
2009-07-10 18:13 ` Peter Zijlstra
2009-07-10 18:29 ` Frederic Weisbecker
2009-07-10 15:00 ` [PATCH 1/2] sched: Drop the need_resched() loop from cond_resched() Peter Zijlstra
2009-07-10 15:17 ` Arnd Bergmann
2009-07-10 15:24 ` Frederic Weisbecker
2009-07-10 15:35 ` Arnd Bergmann
2009-07-10 15:50 ` Frederic Weisbecker
2009-07-10 16:11 ` Ingo Molnar
2009-07-10 16:26 ` Frederic Weisbecker
2009-07-10 17:23 ` [PATCH] sched: Remove obsolete comment in __cond_resched() Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247237391-5352-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox