public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	akpm@linux-foundation.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH] AFS: Fix compilation warning
Date: Tue, 14 Jul 2009 19:19:42 +0530	[thread overview]
Message-ID: <1247579382.11921.7.camel@ht.satnam> (raw)
In-Reply-To: <4131.1247577044@redhat.com>

On Tue, 2009-07-14 at 14:10 +0100, David Howells wrote:
> Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> 
> > 2. fix 80 column wrap problem
> 
> I don't see an 80-column wrap problem that you've removed.
> 

ok here it is :

-               if (fid.vnode != vnode->fid.vnode) {
-                       _debug("%s: dirent changed [%u != %u]",
-                              dentry->d_name.name, fid.vnode,
-                              vnode->fid.vnode);
-                       goto not_found;
-               }

+       if (fid.vnode != vnode->fid.vnode) {
+               _debug("%s: dirent changed [%u != %u]",
+                      dentry->d_name.name, fid.vnode, vnode->fid.vnode);
+               goto not_found;
+       }


-               /* if the vnode ID uniqifier has changed, then the file has
-                * been deleted and replaced, and the original vnode ID has
-                * been reused */

+       /*
+        * if the vnode ID uniqifier has changed, then the file has been
+        * deleted and replaced, and the original vnode ID has been reused
+        */

--
JSR


  reply	other threads:[~2009-07-14 13:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  9:44 [PATCH] AFS: Fix compilation warning David Howells
2009-07-14  8:47 ` Jaswinder Singh Rajput
2009-07-14  8:58   ` Jaswinder Singh Rajput
2009-07-14 13:10     ` David Howells
2009-07-14 13:49       ` Jaswinder Singh Rajput [this message]
2009-07-14 14:16         ` David Howells
2009-07-14 16:17   ` David Howells
2009-07-14 16:36     ` Artem Bityutskiy
2009-07-14 17:22       ` David Howells
  -- strict thread matches above, loose matches on Subject: below --
2009-07-09  8:04 [PATCH] AFS: fix " Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247579382.11921.7.camel@ht.satnam \
    --to=jaswinder@kernel.org \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox