From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: Jaroslav Kysela <erex@perex.cz>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Takashi Iwai <iwai@suse.de>,
Sachin P Sant <sachinp@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/06] Fix compilation warning for sound/soc/codecs/wm8400.c
Date: Wed, 15 Jul 2009 10:13:38 +0530 [thread overview]
Message-ID: <1247633018.2437.5.camel@ht.satnam> (raw)
In-Reply-To: <20090715021826.4032.63752.sendpatchset@subratamodak.linux.ibm.com>
Hello Subrata,
On Wed, 2009-07-15 at 07:48 +0530, Subrata Modak wrote:
> Following fix is inspired by David Howells fix few days back:
> http://lkml.org/lkml/2009/7/9/109,
>
Please check further of this thread :
http://marc.info/?l=linux-kernel&m=124756210124518&w=2
> Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
> ---
>
> --- a/sound/soc/codecs/wm8400.c 2009-06-15 07:52:31.000000000 +0530
> +++ b/sound/soc/codecs/wm8400.c 2009-07-15 05:35:00.000000000 +0530
> @@ -1015,7 +1015,7 @@ static int wm8400_set_dai_pll(struct snd
> {
> struct snd_soc_codec *codec = codec_dai->codec;
> struct wm8400_priv *wm8400 = codec->private_data;
> - struct fll_factors factors;
> + struct fll_factors uninitialized_var(factors);
> int ret;
> u16 reg;
>
>
This kind of warnings born due to not handling the variables properly.
Please try to understand the root cause of this warning, just shutting
this warning is of no use.
Please revise your patches, If you face any problems let me know.
Thanks,
--
JSR
next prev parent reply other threads:[~2009-07-15 4:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 2:18 [PATCH 01/06] Fix compilation warning for sound/soc/codecs/wm8400.c Subrata Modak
2009-07-15 4:43 ` Jaswinder Singh Rajput [this message]
2009-07-15 8:28 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2009-07-16 13:10 Subrata Modak
2009-07-16 13:23 ` [PATCH " Mark Brown
2009-07-16 13:34 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247633018.2437.5.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dhowells@redhat.com \
--cc=erex@perex.cz \
--cc=iwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox