From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Takashi Iwai <tiwai@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: sound/soc/codecs/wm9081.c compiler warning
Date: Wed, 15 Jul 2009 12:00:34 +0530 [thread overview]
Message-ID: <1247639434.2437.14.camel@ht.satnam> (raw)
I am getting this compiler warning in linus tree:
CC [M] sound/soc/codecs/wm9081.o
sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function
This fixes the warning in my case, hope this will be helpful :
diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c
index 86fc57e..77a7997 100644
--- a/sound/soc/codecs/wm9081.c
+++ b/sound/soc/codecs/wm9081.c
@@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)
* not the case, though care must be taken with free
* running mode.
*/
+ new_sysclk = 12288000;
if (wm9081->master && wm9081->bclk) {
/* Make sure we can generate CLK_SYS and BCLK
* and that we've got 3MHz for optimal
@@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)
if (new_sysclk > 3000000)
break;
}
- } else {
- new_sysclk = 12288000;
}
ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK,
--
JSR
next reply other threads:[~2009-07-15 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 6:30 Jaswinder Singh Rajput [this message]
2009-07-15 9:11 ` sound/soc/codecs/wm9081.c compiler warning Takashi Iwai
2009-07-15 9:14 ` Mark Brown
2009-07-15 10:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247639434.2437.14.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox