public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Matthias Urlichs <matthias@urlichs.de>,
	Karsten Keil <kkeil@suse.de>,
	isdn@linux-pingi.de, LKML <linux-kernel@vger.kernel.org>
Subject: drivers/isdn/hardware/mISDN/hfcpci.c compiler warning seems like a BUG
Date: Wed, 15 Jul 2009 12:09:57 +0530	[thread overview]
Message-ID: <1247639997.2437.21.camel@ht.satnam> (raw)

I am getting this compiler warning in linus tree :

  CC [M]  drivers/isdn/hardware/mISDN/hfcpci.o
drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
drivers/isdn/hardware/mISDN/hfcpci.c:2333: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result

static void
hfcpci_softirq(void *arg)
{
        (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
                                        _hfcpci_softirq);

        /* if next event would be in the past ... */
        if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
                hfc_jiffies = jiffies + 1;
        else
                hfc_jiffies += tics;
        hfc_tl.expires = hfc_jiffies;
        add_timer(&hfc_tl);
}

It seems to me it should return is driver_for_each_device fails :
        if (driver_for_each_device(&hfc_driver.driver, NULL, arg,
                                   _hfcpci_softirq))
		return;

or if possible can we return this error code for hfcpci_softirq()

Thanks,
--
JSR



             reply	other threads:[~2009-07-15  6:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15  6:39 Jaswinder Singh Rajput [this message]
2009-07-15 22:23 ` drivers/isdn/hardware/mISDN/hfcpci.c compiler warning seems like a BUG Karsten Keil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247639997.2437.21.camel@ht.satnam \
    --to=jaswinder@kernel.org \
    --cc=isdn@linux-pingi.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias@urlichs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox