HTC Dream: qdsp support for staging

HTC Dream: qdsp support for staging

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

From: Iliyan Malchev <ibm@android.com>

QDSP code is neccessarry for communication with some hardware
components on HTC Dream, including camera hardware. It also drives DSP
coproccessor.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: g1.11.qdsp.diff.gz --]
[-- Type: application/octet-stream, Size: 57857 bytes --]

Re: HTC Dream: qdsp support for staging

[Daniel Walker]

On Fri, 2009-07-10 at 10:37 +0200, Pavel Machek wrote:
> From: Iliyan Malchev <ibm@android.com>
> 
> QDSP code is neccessarry for communication with some hardware
> components on HTC Dream, including camera hardware. It also drives DSP
> coproccessor.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>


You don't want to break it up into multiple patches? I'll do it if you
don't want too ..

Daniel

Re: HTC Dream: qdsp support for staging

[Pavel Machek]

On Fri 2009-07-10 10:25:57, Daniel Walker wrote:
> On Fri, 2009-07-10 at 10:37 +0200, Pavel Machek wrote:
> > From: Iliyan Malchev <ibm@android.com>
> > 
> > QDSP code is neccessarry for communication with some hardware
> > components on HTC Dream, including camera hardware. It also drives DSP
> > coproccessor.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> You don't want to break it up into multiple patches? I'll do it if you
> don't want too ..

I don't know how much sense it makes to split it further... yes, I
could probably split it per file or something but...

(Notice that this is going to be rewriten in staging, anyway, before
merging into kernel proper...)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream: qdsp support for staging

[Daniel Walker]

On Sun, 2009-07-12 at 01:05 +0200, Pavel Machek wrote:
> On Fri 2009-07-10 10:25:57, Daniel Walker wrote:
> > On Fri, 2009-07-10 at 10:37 +0200, Pavel Machek wrote:
> > > From: Iliyan Malchev <ibm@android.com>
> > > 
> > > QDSP code is neccessarry for communication with some hardware
> > > components on HTC Dream, including camera hardware. It also drives DSP
> > > coproccessor.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > You don't want to break it up into multiple patches? I'll do it if you
> > don't want too ..
> 
> I don't know how much sense it makes to split it further... yes, I
> could probably split it per file or something but...
> 
> (Notice that this is going to be rewriten in staging, anyway, before
> merging into kernel proper...)

Your expecting a full re-write? From a quick look this stuff just looks
like it needs some TLC ..

Daniel

Re: HTC Dream: qdsp support for staging

[Pavel Machek]

On Sat 2009-07-11 16:56:44, Daniel Walker wrote:
> On Sun, 2009-07-12 at 01:05 +0200, Pavel Machek wrote:
> > On Fri 2009-07-10 10:25:57, Daniel Walker wrote:
> > > On Fri, 2009-07-10 at 10:37 +0200, Pavel Machek wrote:
> > > > From: Iliyan Malchev <ibm@android.com>
> > > > 
> > > > QDSP code is neccessarry for communication with some hardware
> > > > components on HTC Dream, including camera hardware. It also drives DSP
> > > > coproccessor.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > You don't want to break it up into multiple patches? I'll do it if you
> > > don't want too ..
> > 
> > I don't know how much sense it makes to split it further... yes, I
> > could probably split it per file or something but...
> > 
> > (Notice that this is going to be rewriten in staging, anyway, before
> > merging into kernel proper...)
> 
> Your expecting a full re-write? From a quick look this stuff just looks
> like it needs some TLC ..

I don't know what TLC means.

I expect a lot of changes; I did not study it in great enough detail;
but I suspect that the ammount of changes neccessary will drown any
initial changesets, so I guess it is simpler to just merge it in one piece.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream: qdsp support for staging

[Greg KH]

On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> From: Iliyan Malchev <ibm@android.com>
> 
> QDSP code is neccessarry for communication with some hardware
> components on HTC Dream, including camera hardware. It also drives DSP
> coproccessor.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Please don't compress patches :(

Your patch didn't have any way to actually build the code, care to
respin it and add the proper Kconfig and Makefile hooks?

thanks,

greg k-h

Re: HTC Dream: qdsp support for staging

[Pavel Machek]

On Thu 2009-07-16 16:00:42, Greg KH wrote:
> On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> > From: Iliyan Malchev <ibm@android.com>
> > 
> > QDSP code is neccessarry for communication with some hardware
> > components on HTC Dream, including camera hardware. It also drives DSP
> > coproccessor.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> Please don't compress patches :(

I had to -- in order to fit to lkml maillist limits.

> Your patch didn't have any way to actually build the code, care to
> respin it and add the proper Kconfig and Makefile hooks?

Well, resending 100K+ patch to get 3 missing lines is somewhat
"interesting"... and the problem is that proper Kconfig/Makefile hooks
actually depend on order in which you apply the patches.

Would it be possible to just apply the 3 patches, with me supplying
Kconfig/Makefile hooks in patch #4? That's sometimes used to
aid bisectability, and it would save me quite a lot of work (and
possible mistakes) that way.

[I'd hate to set up quilt just to get 3 lines in Makefile into the
right series of 3 patches, and if I do it by hand there's chance of
mistakes...]

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream: qdsp support for staging

[Greg KH]

On Fri, Jul 17, 2009 at 03:01:57AM +0200, Pavel Machek wrote:
> On Thu 2009-07-16 16:00:42, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> > > From: Iliyan Malchev <ibm@android.com>
> > > 
> > > QDSP code is neccessarry for communication with some hardware
> > > components on HTC Dream, including camera hardware. It also drives DSP
> > > coproccessor.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Please don't compress patches :(
> 
> I had to -- in order to fit to lkml maillist limits.

I have no such limits :)

> > Your patch didn't have any way to actually build the code, care to
> > respin it and add the proper Kconfig and Makefile hooks?
> 
> Well, resending 100K+ patch to get 3 missing lines is somewhat
> "interesting"... and the problem is that proper Kconfig/Makefile hooks
> actually depend on order in which you apply the patches.
> 
> Would it be possible to just apply the 3 patches, with me supplying
> Kconfig/Makefile hooks in patch #4? That's sometimes used to
> aid bisectability, and it would save me quite a lot of work (and
> possible mistakes) that way.

Yes, that would be fine.  Care to send all 4, I've purged the old ones
from my queue.

thanks,

greg k-h

Re: HTC Dream: qdsp support for staging

[Pavel Machek]

On Thu 2009-07-16 18:12:11, Greg KH wrote:
> On Fri, Jul 17, 2009 at 03:01:57AM +0200, Pavel Machek wrote:
> > On Thu 2009-07-16 16:00:42, Greg KH wrote:
> > > On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> > > > From: Iliyan Malchev <ibm@android.com>
> > > > 
> > > > QDSP code is neccessarry for communication with some hardware
> > > > components on HTC Dream, including camera hardware. It also drives DSP
> > > > coproccessor.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > Please don't compress patches :(
> > 
> > I had to -- in order to fit to lkml maillist limits.
> 
> I have no such limits :)

Ok, first 3 patches of resend should be on the way. One of them is
300K, so I hope it gets through.

> > Would it be possible to just apply the 3 patches, with me supplying
> > Kconfig/Makefile hooks in patch #4? That's sometimes used to
> > aid bisectability, and it would save me quite a lot of work (and
> > possible mistakes) that way.
> 
> Yes, that would be fine.  Care to send all 4, I've purged the old ones
> from my queue.

Thanks!
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

HTC Dream for staging

[Pavel Machek]

Hi!

I guess I'm confused. I seem to recall that HTC Dream camera support
was marged into staging, but I can't see it in
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
. Is my memory wrong am I looking at wrong tree?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream for staging

[Greg KH]

On Fri, Jul 17, 2009 at 02:06:57PM +0200, Pavel Machek wrote:
> Hi!
> 
> I guess I'm confused. I seem to recall that HTC Dream camera support
> was marged into staging, but I can't see it in
> http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
> . Is my memory wrong am I looking at wrong tree?

I never merged it.

thanks,

greg k-h

Re: HTC Dream for staging

[Pavel Machek]

On Fri 2009-07-17 06:46:20, Greg KH wrote:
> On Fri, Jul 17, 2009 at 02:06:57PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > I guess I'm confused. I seem to recall that HTC Dream camera support
> > was marged into staging, but I can't see it in
> > http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
> > . Is my memory wrong am I looking at wrong tree?
> 
> I never merged it.

Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue
for all that. They should be all in your inbox now.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream for staging

[Greg KH]

On Fri, Jul 17, 2009 at 03:57:43PM +0200, Pavel Machek wrote:
> On Fri 2009-07-17 06:46:20, Greg KH wrote:
> > On Fri, Jul 17, 2009 at 02:06:57PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > I guess I'm confused. I seem to recall that HTC Dream camera support
> > > was marged into staging, but I can't see it in
> > > http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
> > > . Is my memory wrong am I looking at wrong tree?
> > 
> > I never merged it.
> 
> Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue
> for all that. They should be all in your inbox now.

I see 5 patches, but in the future, please number them to ensure that
they are applied in the correct order.

thanks,

greg k-h

Re: HTC Dream for staging

[Pavel Machek]

On Fri 2009-07-17 07:14:40, Greg KH wrote:
> On Fri, Jul 17, 2009 at 03:57:43PM +0200, Pavel Machek wrote:
> > On Fri 2009-07-17 06:46:20, Greg KH wrote:
> > > On Fri, Jul 17, 2009 at 02:06:57PM +0200, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > I guess I'm confused. I seem to recall that HTC Dream camera support
> > > > was marged into staging, but I can't see it in
> > > > http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
> > > > . Is my memory wrong am I looking at wrong tree?
> > > 
> > > I never merged it.
> > 
> > Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue
> > for all that. They should be all in your inbox now.
> 
> I see 5 patches, but in the future, please number them to ensure that
> they are applied in the correct order.

Ok... And, sorry for all the trouble.

(BTW: I do not see the patches in the git tree, yet, and the tree is
labeled as "junk tree, please ignore". Should I just wait a bit? Or is
staging maintained outside of git? Or should the description be
updated?)

Thanks!
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: HTC Dream for staging

[Daniel Walker]

On Sat, 2009-07-18 at 12:41 +0200, Pavel Machek wrote:

> (BTW: I do not see the patches in the git tree, yet, and the tree is
> labeled as "junk tree, please ignore". Should I just wait a bit? Or is
> staging maintained outside of git? Or should the description be
> updated?)

Staging is a quilt tree .. In Linux-next Next/Trees has it listed as,

staging         quilt   http://kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-05-staging/

I guess it was once a git tree, but was changed over at some point.

Daniel

Re: HTC Dream for staging

[Greg KH]

On Sat, Jul 18, 2009 at 06:53:11AM -0700, Daniel Walker wrote:
> On Sat, 2009-07-18 at 12:41 +0200, Pavel Machek wrote:
> 
> > (BTW: I do not see the patches in the git tree, yet, and the tree is
> > labeled as "junk tree, please ignore". Should I just wait a bit? Or is
> > staging maintained outside of git? Or should the description be
> > updated?)
> 
> Staging is a quilt tree .. In Linux-next Next/Trees has it listed as,
> 
> staging         quilt   http://kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-05-staging/
> 
> I guess it was once a git tree, but was changed over at some point.

The "junk tree" you see is what I used to send stuff to Linus.

Use the quilt tree above, or linux-next, it has the stuff in it as well.

thanks,

greg k-h