From: Peter Zijlstra <peterz@infradead.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: save ARCH & CROSS_COMPILE when building a kernel
Date: Mon, 20 Jul 2009 14:00:43 +0200 [thread overview]
Message-ID: <1248091243.15751.8550.camel@twins> (raw)
In-Reply-To: <20090720115134.GA6517@merkur.ravnborg.org>
On Mon, 2009-07-20 at 13:51 +0200, Sam Ravnborg wrote:
> -if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi
> -if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/${CROSS_COMPILE}installkernel "$@"; fi
> +for INSTALL in ~/bin/${CROSS_COMPILE} /sbin/${CROSS_COMPILE} ~/bin /sbin/; do
> + if [ -x ${INSTALL}installkernel ]; then
> + exec ${INSTALL}installkernel "$@"
> + fi
> +done
Won't that still get upset if CROSS_COMPILE has whitespace in it, which
would form weird filenames etc.. or worse, it might match ~/bin/distcc
next prev parent reply other threads:[~2009-07-20 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 10:01 [PATCH] kbuild: save ARCH & CROSS_COMPILE when building a kernel Sam Ravnborg
2009-07-20 10:34 ` Peter Zijlstra
2009-07-20 11:51 ` Sam Ravnborg
2009-07-20 12:00 ` Peter Zijlstra [this message]
2009-07-20 17:12 ` Sam Ravnborg
2009-07-20 20:05 ` Sam Ravnborg
2009-07-20 20:13 ` Peter Zijlstra
2009-07-20 21:05 ` Mike Frysinger
2009-10-09 9:02 ` Peter Zijlstra
2009-10-11 21:43 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248091243.15751.8550.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox