public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David P. Quigley" <dpquigl@tycho.nsa.gov>
To: jmorris@namei.org
Cc: sds@tycho.nsa.gov, Greg KH <greg@kroah.com>,
	casey@schaufler-ca.com, ebiederm@xmission.com,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] Security/sysfs: Enable security xattrs to be set on sysfs files, directories, and symlinks.
Date: Tue, 21 Jul 2009 13:01:40 -0400	[thread overview]
Message-ID: <1248195700.10726.28.camel@localhost> (raw)
In-Reply-To: <1248194067.10726.22.camel@localhost>

On Tue, 2009-07-21 at 12:34 -0400, David P. Quigley wrote:
> I've found a problem with the patch that I want to fix. So I will be
> posting another version of it soon.
> 
> Dave
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Looking more closely at the problem I was mistaken. I was concerned with
the dereferenceing of the dentry in the first line of the getxattr
function but it seems that a precondition for us getting that far is
that we will always have a valid dentry at that point. I'd appreciate it
if the people whose code the patch touches can review the patch again
and either NAK with more comments or sign off on it.

Dave


  reply	other threads:[~2009-07-21 17:11 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 13:48 [PATCH] Security/sysfs: Enable security xattrs to be set on sysfs files, directories, and symlinks David P. Quigley
2009-07-15 14:28 ` David P. Quigley
2009-07-15 14:31 ` David P. Quigley
2009-07-21 16:29 ` David P. Quigley
2009-07-21 16:49   ` Greg KH
2009-07-21 16:34 ` David P. Quigley
2009-07-21 17:01   ` David P. Quigley [this message]
2009-07-24  8:13     ` James Morris
2009-07-24 14:34       ` David P. Quigley
2009-07-24 14:54         ` Casey Schaufler
2009-08-14  4:59 ` Casey Schaufler
2009-08-14 12:20   ` Stephen Smalley
2009-08-14 12:40     ` Stephen Smalley
2009-08-15  1:33       ` Casey Schaufler
2009-08-17 12:01         ` Stephen Smalley
2009-08-15  1:19     ` Casey Schaufler
2009-08-17 11:53       ` Stephen Smalley
2009-08-14 22:02   ` Eric W. Biederman
2009-08-15  1:42     ` Casey Schaufler
2009-08-15  2:15       ` Eric W. Biederman
2009-08-15  4:56         ` Casey Schaufler
2009-08-15  6:01           ` Eric W. Biederman
2009-08-16 17:25             ` Casey Schaufler
2009-08-18  3:55             ` [PATCH] Security/sysfs: v2 - " Casey Schaufler
2009-08-18 12:14               ` Stephen Smalley
2009-08-18 14:12                 ` Casey Schaufler
2009-08-18 14:23                   ` Stephen Smalley
2009-08-19  4:37                     ` Casey Schaufler
2009-08-19 11:58                       ` Stephen Smalley
2009-08-19 17:47                         ` Casey Schaufler
2009-08-19 23:59                         ` Casey Schaufler
2009-08-20  2:41                           ` Eric W. Biederman
2009-08-20 11:53                             ` Stephen Smalley
2009-08-20 13:18 ` [PATCH] Security/sysfs: " David P. Quigley
2009-08-21  3:38   ` Casey Schaufler
  -- strict thread matches above, loose matches on Subject: below --
2009-09-03 18:25 David P. Quigley
2009-07-08 17:28 David P. Quigley
2009-07-09  1:44 ` Casey Schaufler
2009-07-09 14:05   ` David P. Quigley
2009-07-09 14:49     ` Casey Schaufler
2009-07-09 14:56       ` David P. Quigley
2009-07-09 15:16       ` David P. Quigley
2009-07-09 15:16     ` Greg KH
2009-07-09 14:11   ` David P. Quigley
2009-07-09 17:26   ` David P. Quigley
2009-07-09 17:50     ` Greg KH
2009-07-09 19:32       ` David P. Quigley
2009-07-09 20:13         ` Greg KH
2009-07-10  3:25         ` Casey Schaufler
2009-07-13 15:07           ` David P. Quigley
2009-07-09 15:18 ` Greg KH
2009-07-09 17:13   ` David P. Quigley
2009-07-09 17:52     ` Greg KH
2009-07-09 19:28       ` David P. Quigley
2009-07-09 20:12         ` Greg KH
2009-07-09 20:19           ` David P. Quigley
2009-07-09 20:41             ` Greg KH
2009-07-14 16:37               ` David P. Quigley
2009-07-14 17:50                 ` Greg KH
2009-07-14 20:16                   ` David P. Quigley
2009-07-14 20:35                     ` Greg KH
2009-07-14 20:35                       ` David P. Quigley
     [not found] ` <m1r5wmnee0.fsf@fess.ebiederm.org>
     [not found]   ` <1247498399.4398.259.camel@localhost>
2009-07-13 16:50     ` Eric W. Biederman
2009-07-13 19:18       ` David P. Quigley
2009-07-14  0:29         ` Eric W. Biederman
2009-07-14 13:55           ` David P. Quigley
2009-07-14  3:06         ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248195700.10726.28.camel@localhost \
    --to=dpquigl@tycho.nsa.gov \
    --cc=casey@schaufler-ca.com \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox