From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, tglx@linutronix.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kaber@trash.net
Subject: Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq
Date: Wed, 22 Jul 2009 08:29:44 +0200 [thread overview]
Message-ID: <1248244184.27058.992.camel@twins> (raw)
In-Reply-To: <20090721.201855.32703627.davem@davemloft.net>
On Tue, 2009-07-21 at 20:18 -0700, David Miller wrote:
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Fri, 17 Jul 2009 14:14:52 +0200
>
> > On Tue, 2009-07-14 at 09:42 -0700, Linus Torvalds wrote:
> >>
> >> On Tue, 14 Jul 2009, Peter Zijlstra wrote:
> >> >
> >> > Linus really hated the softirq mode, which is what prompted me to change
> >> > that.
> >> >
> >> > Now, it might be he only hated the particular interface and the
> >> > resulting code, but I think to remember he simply thought the whole
> >> > thing daft.
> >>
> >> Yes. And I hated the bugs it had.
> >>
> >> Don't make something as core as timers any more complicated. Don't take
> >> locks in timers and then complain about deadlocks. If your locking is
> >> broken, don't make the core timers be idiotically broken.
> >>
> >> Because it was. The code was a total mess to follow, and had bugs.
> >
> > How would something like the below work for people?
>
> I like it, but like Linus said it probably belongs in
> kernel/softirq.c
Right, I meant to rework it, but stuff kept preempting me. I'll try and
get around to it today :-)
next prev parent reply other threads:[~2009-07-22 6:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 21:59 [patch 0/3] net: Sanitizing hrtimer usage in net/sched/sch_cbq.c Thomas Gleixner
2009-07-09 21:59 ` [patch 1/3] net: serialize hrtimer callback in sched_cbq Thomas Gleixner
2009-07-12 20:55 ` David Miller
2009-07-14 8:22 ` Patrick McHardy
2009-07-14 8:30 ` Peter Zijlstra
2009-07-14 16:01 ` David Miller
2009-07-14 8:55 ` Thomas Gleixner
2009-07-14 16:00 ` David Miller
2009-07-14 16:28 ` Peter Zijlstra
2009-07-14 16:42 ` Linus Torvalds
2009-07-17 12:14 ` Peter Zijlstra
2009-07-17 13:26 ` Oliver Hartkopp
2009-07-17 15:44 ` Linus Torvalds
2009-07-22 3:18 ` David Miller
2009-07-22 6:29 ` Peter Zijlstra [this message]
2009-07-22 12:28 ` [PATCH] softirq: tasklet_hrtimer Peter Zijlstra
2009-07-22 14:01 ` [tip:timers/urgent] softirq: introduce tasklet_hrtimer infrastructure tip-bot for Peter Zijlstra
2009-07-22 15:03 ` [tip:core/urgent] " tip-bot for Peter Zijlstra
2009-07-22 15:39 ` [PATCH] softirq: tasklet_hrtimer David Miller
2009-07-22 16:01 ` Linus Torvalds
2009-07-15 9:56 ` [patch 1/3] net: serialize hrtimer callback in sched_cbq Oliver Hartkopp
2009-07-09 21:59 ` [patch 2/3] net: sanitize hrtimer usage " Thomas Gleixner
2009-07-09 21:59 ` [patch 3/3] net: use HRTIMER_RESTART " Thomas Gleixner
2009-07-10 0:39 ` [patch 0/3] net: Sanitizing hrtimer usage in net/sched/sch_cbq.c David Miller
2009-07-12 20:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248244184.27058.992.camel@twins \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox