Re: inotify regression, missing events

Eric Paris
2009-07-25T22:28:21Z

On Sun, 2009-07-26 at 00:23 +0200, Rafael J. Wysocki wrote:
> On Monday 13 July 2009, Eric Paris wrote:
> > On Mon, 2009-07-13 at 13:21 +0100, Scott James Remnant wrote:
> > > On Sat, 2009-07-11 at 07:50 -0400, Eric Paris wrote:
> > >
> > > > On Sat, 2009-07-11 at 17:02 +0100, Scott James Remnant wrote:
> > > > > Looks like there's a regression with inotify since the rewrite to use
> > > > > fanotify. Events are simply missing and not being delivered to
> > > > > userspace.
> > > > >
> > > > > Here's a simple test case, just compile and run it:
> > > >
> > > > I bet I know exactly what it is (notification.c tail merge code isn't
> > > > comparing filename only inode+mask) but I'm walking out of the house.
> > > > I'll try my theory later tonight and post a patch.
> > > >
> > > > Stupid Eric, Stupid.
> > > >
> > > In other words, when the second deleted-file-in-a-directory event comes
> > > through, it gets ignored because there's already a
> > > "deleted-file-in-a-directory" event for that directory?
> >
> > Yes, and I sent a patch but apparent screwed up the --smtp-server option
> > so it never got out. Resending. Sorry.....
>
> Did the patch reach Linus eventually?

No, I sent a git-pull but Linus did not pull from my tree before -rc4.
If he doesn't do it in his openning -rc5 salvo I'll send the request
again.

-Eric