From: Stefani Seibold <stefani@seibold.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] fbcon: rotate upside down crash
Date: Tue, 28 Jul 2009 10:01:58 +0200 [thread overview]
Message-ID: <1248768118.2992.12.camel@wall-e> (raw)
Attached is a bug fix for the frame console.
The current frame buffer console upside down functionality will crash
using a font which has not a width of multiple by 8.
The following 1 liner will fix the rotate_ud() function,
ChangeLog:
Fix the rotate_ud() function not to crash in case of a font which has not a width of multiple by 8: The
inner loop of the font pixel copy should not access a bit outside the font memory area. Subtract the shift
offset from the font width will prevent this.
fbcon_rotate.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Stefani Seibold <stefani@seibold.net>
--- linux-2.6.31-rc4.orig/drivers/video/console/fbcon_rotate.h 2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.31-rc4/drivers/video/console/fbcon_rotate.h 2009-07-24 20:37:31.000000000 +0200
@@ -45,7 +45,7 @@
width = (width + 7) & ~7;
for (i = 0; i < height; i++) {
- for (j = 0; j < width; j++) {
+ for (j = 0; j < width - shift; j++) {
if (pattern_test_bit(j, i, width, in))
pattern_set_bit(width - (1 + j + shift),
height - (1 + i),
next reply other threads:[~2009-07-28 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 8:01 Stefani Seibold [this message]
2009-07-29 20:28 ` [PATCH] fbcon: rotate upside down crash Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2009-07-24 19:23 Stefani Seibold
2009-07-27 23:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248768118.2992.12.camel@wall-e \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox