From: Daniel Walker <dwalker@fifo99.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions
Date: Wed, 29 Jul 2009 08:52:50 -0700 [thread overview]
Message-ID: <1248882770.28841.236.camel@desktop> (raw)
In-Reply-To: <20090729173231.012d0b89@skybase>
On Wed, 2009-07-29 at 17:32 +0200, Martin Schwidefsky wrote:
> Hmm, you have an object of type struct clocksource and you do
> cs->read(cs). If that is not clear enough then I don't know what is.
It's not as clear as it could be .. In the case above you have to look
in at least two places to know what's going on.. First to see the
cs->read() , and second to see if "cs" is actually a clocksource or
something else.. "cs" could be declared anyplace with any name.
If you see clocksource_read(cs) , you might need to once check what
clocksource_read() is actually doing, but only once.. After that when
you see that function you know that variable is a clocksource, and it's
"read()" is getting called. So you only need to review one line in the
simplest case.
Daniel
next prev parent reply other threads:[~2009-07-29 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907291457.n6TEvDAt003701@d06av06.portsmouth.uk.ibm.com>
2009-07-29 15:32 ` [RFC][patch 02/12] remove clocksource inline functions Martin Schwidefsky
2009-07-29 15:36 ` Will Newton
2009-07-29 16:27 ` Martin Schwidefsky
2009-07-29 16:44 ` Martin Schwidefsky
2009-07-30 12:21 ` Valdis.Kletnieks
2009-07-30 21:48 ` Christoph Hellwig
2009-07-31 11:50 ` Valdis.Kletnieks
2009-08-03 8:10 ` Martin Schwidefsky
2009-07-29 15:52 ` Daniel Walker [this message]
2009-07-29 16:37 ` Martin Schwidefsky
[not found] <200907291415.n6TEFJkA019086@d06av05.portsmouth.uk.ibm.com>
2009-07-29 14:44 ` Martin Schwidefsky
2009-07-29 14:57 ` Daniel Walker
2009-07-29 13:41 [RFC][patch 00/12] clocksource / timekeeping rework V2 Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 02/12] remove clocksource inline functions Martin Schwidefsky
2009-07-29 14:15 ` Daniel Walker
2009-07-30 21:46 ` Christoph Hellwig
2009-07-30 21:05 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248882770.28841.236.camel@desktop \
--to=dwalker@fifo99.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox