Re: [RFC][patch 00/12] clocksource / timekeeping rework V2

Daniel Walker
2009-07-29T17:34:38Z

On Wed, 2009-07-29 at 19:09 +0200, Martin Schwidefsky wrote:
> On Wed, 29 Jul 2009 11:02:21 -0600
> dwalker@fifo99.com wrote:
>
> > On Wed, 2009-07-29 at 18:50 +0200, Martin Schwidefsky wrote:
> >
> > > void clocksource_change_rating(struct clocksource *cs, int rating)
> >
> > > the two functions do different things. What exactly is the idea you've
> > > got in mind?
> >
> > It's only the case when the rating goes to zero .. That makes the
> > clocksource unusable, which is very much like unregistering it..
>
> True, the clocksource code won't pick the clock any more as long as
> there is an alternative clock available. It still shows up in the list
> of clocks though and you can do an override with it.

Now that you mention it, if the clocks are sorted by rating (something
your removing) then the sysfs override available listing isn't in rated
order .. So if you do have zero rated clocks you wouldn't have any idea
from looking at the available list.. It could be solved just by printing
them in rated order in the sysfs code tho.