From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbZHAINT (ORCPT ); Sat, 1 Aug 2009 04:13:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751935AbZHAINT (ORCPT ); Sat, 1 Aug 2009 04:13:19 -0400 Received: from www84.your-server.de ([213.133.104.84]:39147 "EHLO www84.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbZHAINR (ORCPT ); Sat, 1 Aug 2009 04:13:17 -0400 Subject: [PATCH] ctags usability fix From: Stefani Seibold To: linux-kernel@vger.kernel.org, Andrew Morton Content-Type: text/plain Date: Sat, 01 Aug 2009 10:13:13 +0200 Message-Id: <1249114393.19594.16.camel@wall-e> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: stefani@seibold.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, the tag file generated by the tags.sh script has some issue. First: The identifier-list miss the DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL special handling, which can result in a wrong tag, not to jump to the right variable definition or function implementation. Second: It makes no real sense to include function prototypes and external and forward variable declarations, because jumping to a tag will sometimes go to this and not to the real definition and implementation. The information about the declaration is still there at the definition and implementation place. So this patch make it lot easier to navigate through the kernel source tree using vi. Greetings, Stefani tags.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Signed-off-by: Stefani Seibold --- linux-2.6.30.orig/scripts/tags.sh 2009-06-10 05:05:27.000000000 +0200 +++ linux-2.6.30/scripts/tags.sh 2009-08-01 09:46:56.000000000 +0200 @@ -101,7 +101,8 @@ -I ____cacheline_aligned_in_smp \ -I ____cacheline_internodealigned_in_smp \ -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ - --extra=+f --c-kinds=+px \ + -I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \ + --extra=+f --c-kinds=-px \ --regex-asm='/^ENTRY\(([^)]*)\).*/\1/' \ --regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'