From: Alok Kataria <akataria@vmware.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>
Cc: the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: VMI fix for stack protector
Date: Tue, 04 Aug 2009 15:34:22 -0700 [thread overview]
Message-ID: <1249425262.18955.40.camel@ank32.eng.vmware.com> (raw)
With CONFIG_STACK_PROTECTOR turned on, VMI doesn't boot with more than one
processor. The problem is with the gs value not being initialized correctly
when registering the secondary processor for VMI's case.
The patch below initializes the gs value for the AP to __KERNEL_STACK_CANARY.
Without this the secondary processor keeps on taking a GP on every gs access.
Needs to go in for 2.6.30.x too, since STACK_PROTECTOR for 32bit was
introduced in 2.6.30.
Patch on top of 2.6.31-rc5.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Cc: stable@kernel.org
Index: linux-2.6/arch/x86/kernel/vmi_32.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/vmi_32.c 2009-08-03 13:55:41.000000000 -0700
+++ linux-2.6/arch/x86/kernel/vmi_32.c 2009-08-04 14:13:22.000000000 -0700
@@ -442,7 +442,7 @@ vmi_startup_ipi_hook(int phys_apicid, un
ap.ds = __USER_DS;
ap.es = __USER_DS;
ap.fs = __KERNEL_PERCPU;
- ap.gs = 0;
+ ap.gs = __KERNEL_STACK_CANARY;
ap.eflags = 0;
next reply other threads:[~2009-08-04 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 22:34 Alok Kataria [this message]
2009-08-05 9:57 ` [tip:x86/urgent] x86: Fix VMI && stack protector tip-bot for Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249425262.18955.40.camel@ank32.eng.vmware.com \
--to=akataria@vmware.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox