From: Ramon de Carvalho Valle <ramon@risesecurity.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
linux-kernel@vger.kernel.org, mszeredi@novell.com, hch@lst.de,
xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check
Date: Wed, 05 Aug 2009 13:34:02 -0300 [thread overview]
Message-ID: <1249490042.7725.16.camel@logos> (raw)
In-Reply-To: <20090805151750.GA16080@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Wed, 2009-08-05 at 11:17 -0400, Christoph Hellwig wrote:
> On Tue, Aug 04, 2009 at 03:51:38PM -0300, Ramon de Carvalho Valle wrote:
> > The xfs_iformat function does not check if the realtime device target pointer
> > is valid when the XFS_DIFLAG_REALTIME flag is set on the ondisk inode
> > structure.
>
> Same as Eric I don't think there's much of a point renumbering the error
> cases. Instead I'll do another patch with a couple of cleanups in this
> function replacing all the numbers with short alphabetic tags.
Great. Thanks.
>
> I don't really see the point of printing the flags either, if we have
> this bit flipped it's pretty clear that we had random corruption of this
> dinode.
>
Printing the flags is just for debugging purposes and it keeps the code
consistent with the other calls to xfs_fs_repair_cmn_err.
-Ramon
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-08-05 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 20:03 [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target device Ramon de Carvalho Valle
2009-08-03 21:49 ` Christoph Hellwig
2009-08-04 2:00 ` Ramon de Carvalho Valle
2009-08-04 14:31 ` Christoph Hellwig
2009-08-04 16:25 ` Eric Sandeen
2009-08-04 18:50 ` Ramon de Carvalho Valle
2009-08-04 18:51 ` [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check Ramon de Carvalho Valle
2009-08-04 19:11 ` Eric Sandeen
2009-08-05 3:55 ` Ramon de Carvalho Valle
2009-08-05 4:15 ` Eric Sandeen
2009-08-05 13:21 ` Ramon de Carvalho Valle
2009-08-05 21:53 ` Felix Blyakher
2009-08-05 15:17 ` Christoph Hellwig
2009-08-05 16:34 ` Ramon de Carvalho Valle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249490042.7725.16.camel@logos \
--to=ramon@risesecurity.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@novell.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox