From: Daniel Mack <daniel@caiaq.de>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@lists.linux-foundation.org,
Daniel Mack <daniel@caiaq.de>,
Steve Glendinning <steve.glendinning@smsc.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: [PATCH 5/5] net: smsc911x: switch to new dev_pm_ops
Date: Wed, 5 Aug 2009 20:29:31 +0200 [thread overview]
Message-ID: <1249496971-9019-5-git-send-email-daniel@caiaq.de> (raw)
In-Reply-To: <1249496971-9019-4-git-send-email-daniel@caiaq.de>
Hibernation is unsupported for now, which meets the actual
implementation in the driver. For free/thaw, the chip's D2 state should
be entered.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Steve Glendinning <steve.glendinning@smsc.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
drivers/net/smsc911x.c | 31 ++++++++++++++++++++-----------
1 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index 94b6d26..c266785 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -50,6 +50,7 @@
#include <linux/swab.h>
#include <linux/phy.h>
#include <linux/smsc911x.h>
+#include <linux/device.h>
#include "smsc911x.h"
#define SMSC_CHIPNAME "smsc911x"
@@ -2114,10 +2115,12 @@ out_0:
/* This implementation assumes the devices remains powered on its VDDVARIO
* pins during suspend. */
-static int smsc911x_suspend(struct platform_device *pdev, pm_message_t state)
+/* TODO: implement freeze/thaw callbacks for hibernation.*/
+
+static int smsc911x_suspend(struct device *dev)
{
- struct net_device *dev = platform_get_drvdata(pdev);
- struct smsc911x_data *pdata = netdev_priv(dev);
+ struct net_device *ndev = dev_get_drvdata(dev);
+ struct smsc911x_data *pdata = netdev_priv(ndev);
/* enable wake on LAN, energy detection and the external PME
* signal. */
@@ -2128,10 +2131,10 @@ static int smsc911x_suspend(struct platform_device *pdev, pm_message_t state)
return 0;
}
-static int smsc911x_resume(struct platform_device *pdev)
+static int smsc911x_resume(struct device *dev)
{
- struct net_device *dev = platform_get_drvdata(pdev);
- struct smsc911x_data *pdata = netdev_priv(dev);
+ struct net_device *ndev = dev_get_drvdata(dev);
+ struct smsc911x_data *pdata = netdev_priv(ndev);
unsigned int to = 100;
/* Note 3.11 from the datasheet:
@@ -2149,19 +2152,25 @@ static int smsc911x_resume(struct platform_device *pdev)
return (to == 0) ? -EIO : 0;
}
+static struct dev_pm_ops smsc911x_pm_ops = {
+ .suspend = smsc911x_suspend,
+ .resume = smsc911x_resume,
+};
+
+#define SMSC911X_PM_OPS (&smsc911x_pm_ops)
+
#else
-#define smsc911x_suspend NULL
-#define smsc911x_resume NULL
+#define SMSC911X_PM_OPS NULL
#endif
static struct platform_driver smsc911x_driver = {
.probe = smsc911x_drv_probe,
.remove = __devexit_p(smsc911x_drv_remove),
.driver = {
- .name = SMSC_CHIPNAME,
+ .name = SMSC_CHIPNAME,
+ .owner = THIS_MODULE,
+ .pm = SMSC911X_PM_OPS,
},
- .suspend = smsc911x_suspend,
- .resume = smsc911x_resume,
};
/* Entry point for loading the module */
--
1.6.3.3
next prev parent reply other threads:[~2009-08-05 18:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 18:29 [PATCH 1/5] w1_gpio: switch to new dev_pm_ops Daniel Mack
2009-08-05 18:29 ` [PATCH 2/5] pda-power: " Daniel Mack
2009-08-05 18:29 ` [PATCH 3/5] ds2760: " Daniel Mack
2009-08-05 18:29 ` [PATCH 4/5] input: gpio-keys: " Daniel Mack
2009-08-05 18:29 ` Daniel Mack [this message]
2009-08-06 3:29 ` [PATCH 5/5] net: smsc911x: " David Miller
2009-08-06 11:53 ` Steve.Glendinning
2009-08-06 20:26 ` David Miller
2009-08-05 20:15 ` [PATCH 4/5] input: gpio-keys: " pHilipp Zabel
2009-08-05 22:33 ` Daniel Mack
2009-08-06 0:51 ` [linux-pm] " Rafael J. Wysocki
2009-08-06 12:59 ` Daniel Mack
2009-08-06 15:19 ` Rafael J. Wysocki
2009-08-07 13:39 ` pHilipp Zabel
2009-08-05 19:49 ` [PATCH 2/5] pda-power: " Frans Pop
2009-08-05 22:29 ` Daniel Mack
2009-08-06 11:52 ` pHilipp Zabel
2009-08-06 12:56 ` Daniel Mack
2009-08-07 13:35 ` pHilipp Zabel
2009-09-04 16:34 ` Anton Vorontsov
2009-08-05 18:44 ` [PATCH 1/5] w1_gpio: " Rafael J. Wysocki
2009-08-05 18:45 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249496971-9019-5-git-send-email-daniel@caiaq.de \
--to=daniel@caiaq.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox