public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, zhifeng.cai@atheros.com,
	stephen.chen@atheros.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
Date: Wed, 05 Aug 2009 21:35:57 -0700	[thread overview]
Message-ID: <1249533357.21101.5.camel@localhost.localdomain> (raw)
In-Reply-To: <43e72e890908052126v53aa1b4sb7a48e19f98fdfa6@mail.gmail.com>

Hi Luiz,

> >> New Atheros USB devices will use 0x0cf3. The first device
> >> will be ar9271, for which we are adding support for.
> >>
> >> Cc: zhifeng.cai@atheros.com
> >> Cc: stephen.chen@atheros.com
> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> >> ---
> >>
> >> John, sending this through you as this is only
> >> specific to wireless, at least at the moment.
> >>
> >>  include/linux/pci_ids.h |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> >> index 73b46b6..27f4e6b 100644
> >> --- a/include/linux/pci_ids.h
> >> +++ b/include/linux/pci_ids.h
> >> @@ -2170,6 +2170,7 @@
> >>  #define PCI_DEVICE_ID_BCM1250_HT     0x0002
> >>
> >>  #define PCI_VENDOR_ID_ATHEROS                0x168c
> >> +#define PCI_VENDOR_ID_ATHEROS_USB    0x0cf3
> >
> > this is confusing the hell out of me. What are you adding here.
> 
> No you're right, my fault.
> 
> > A USB
> > vendor id or a PCI one. Is the ar9271 a PCI device or a USB device?
> 
> Its only USB.
> 
> Thanks... hm I see no USB vendor id headers. Guess we won't need to add this.

the closest we have is drivers/hid/hid-ids.h and we might just should
have Greg create a usb-ids.h file.

Regards

Marcel



  reply	other threads:[~2009-08-06  4:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06  1:59 [PATCH] pci_ids.h: add new Atheros USB vendor ID Luis R. Rodriguez
2009-08-06  4:16 ` Marcel Holtmann
2009-08-06  4:26   ` Luis R. Rodriguez
2009-08-06  4:35     ` Marcel Holtmann [this message]
2009-08-06  5:09       ` Greg KH
2009-08-06  6:17         ` Marcel Holtmann
2009-08-06 18:15         ` Dave Jones
2009-08-06 18:16           ` John W. Linville
2009-08-06 18:33           ` Greg KH
2009-08-06 19:13             ` [PATCH] Document pci_ids.h addition policy Dave Jones
2009-08-06 19:16               ` John W. Linville
2009-08-06 19:38               ` Greg KH
2009-08-10 16:28               ` Jesse Barnes
2009-08-06 18:50           ` [PATCH] pci_ids.h: add new Atheros USB vendor ID Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249533357.21101.5.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=stephen.chen@atheros.com \
    --cc=zhifeng.cai@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox