From: tom.leiming@gmail.com
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org,
akpm@linux-foundation.org, Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH 1/2] driver core: introduce devtmpfs_wait_for_dev() v1
Date: Thu, 6 Aug 2009 17:40:02 +0800 [thread overview]
Message-ID: <1249551602-13147-1-git-send-email-tom.leiming@gmail.com> (raw)
From: Ming Lei <tom.leiming@gmail.com>
This patch introduces devtmpfs_wait_for_dev(), which is based on devtmpfs
and can be used to remove polling for root device before mounting rootfs.
This patch also gives a generic and simple way to wait for a device in
kernel mode based on devtmpfs.
This version takes Kay Sievers's suggestion: pass relative path to
devtmpfs_wait_for_dev(), for devtmpfs has no clue where it is
mounted.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/base/devtmpfs.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
include/linux/device.h | 7 ++++++
2 files changed, 57 insertions(+), 0 deletions(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 51c410f..3a04252 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -30,6 +30,9 @@ static int dev_mount = 1;
static int dev_mount;
#endif
+static DECLARE_WAIT_QUEUE_HEAD(devtmpfs_waitqueue);
+
+
static int __init mount_param(char *str)
{
dev_mount = simple_strtoul(str, NULL, 0);
@@ -178,6 +181,10 @@ int devtmpfs_create_node(struct device *dev)
path_put(&nd.path);
out:
+ /*notify others that we have created a dev node*/
+ if (!err)
+ wake_up(&devtmpfs_waitqueue);
+
kfree(tmp);
revert_creds(curr_cred);
return err;
@@ -310,6 +317,49 @@ out:
return err;
}
+static int devtmpfs_query_dev(const char *nodename)
+{
+ const struct cred *curr_cred;
+ struct nameidata nd;
+ struct dentry *dentry;
+ int err;
+
+ if (!dev_mnt)
+ return -ENOENT;
+
+ curr_cred = override_creds(&init_cred);
+ err = vfs_path_lookup(dev_mnt->mnt_root, dev_mnt,
+ nodename, LOOKUP_PARENT, &nd);
+ if (err)
+ goto out;
+
+ mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT);
+ dentry = lookup_one_len(nd.last.name, nd.path.dentry, nd.last.len);
+ if (!IS_ERR(dentry)) {
+ if (dentry->d_inode)
+ err = 0;
+ else
+ err = -ENOENT;
+ dput(dentry);
+ } else {
+ err = PTR_ERR(dentry);
+ }
+ mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
+
+ path_put(&nd.path);
+out:
+ revert_creds(curr_cred);
+ return err;
+}
+
+int devtmpfs_wait_for_dev(const char *dev_name, unsigned long seconds)
+{
+
+ return wait_event_timeout(devtmpfs_waitqueue,
+ devtmpfs_query_dev(dev_name) == 0,
+ seconds*HZ);
+}
+
/*
* If configured, or requested by the commandline, devtmpfs will be
* auto-mounted after the kernel mounted the root filesystem.
diff --git a/include/linux/device.h b/include/linux/device.h
index 65f5b5a..1fa1b19 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -557,10 +557,17 @@ extern void wait_for_device_probe(void);
extern int devtmpfs_create_node(struct device *dev);
extern int devtmpfs_delete_node(struct device *dev);
extern int devtmpfs_mount(const char *mountpoint);
+extern int devtmpfs_wait_for_dev(const char *dev_path,
+ unsigned long seconds);
#else
static inline int devtmpfs_create_node(struct device *dev) { return 0; }
static inline int devtmpfs_delete_node(struct device *dev) { return 0; }
static inline int devtmpfs_mount(const char *mountpoint) { return 0; }
+static inline int devtmpfs_wait_for_dev(const char *dev_path,
+ unsigned long seconds)
+{
+ return 0;
+}
#endif
/* drivers/base/power/shutdown.c */
--
1.6.0.GIT
next reply other threads:[~2009-08-06 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 9:40 tom.leiming [this message]
2009-09-17 14:01 ` [PATCH 1/2] driver core: introduce devtmpfs_wait_for_dev() v1 Ming Lei
2009-09-18 6:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249551602-13147-1-git-send-email-tom.leiming@gmail.com \
--to=tom.leiming@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox