From: "David Xiao" <dxiao@broadcom.com>
To: "Catalin Marinas" <catalin.marinas@arm.com>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Ben Dooks" <ben-linux@fluff.org>,
"Hugh Dickins" <hugh.dickins@tiscali.co.uk>,
"Robin Holt" <holt@sgi.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
v4l2_linux <linux-media@vger.kernel.org>,
"linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: How to efficiently handle DMA and cache on ARMv7 ? (was "Is get_user_pages() enough to prevent pages from being swapped out ?")
Date: Tue, 11 Aug 2009 11:23:10 -0700 [thread overview]
Message-ID: <1250014990.14439.4.camel@david-laptop> (raw)
In-Reply-To: <1249983062.27150.20.camel@pc1117.cambridge.arm.com>
On Tue, 2009-08-11 at 02:31 -0700, Catalin Marinas wrote:
> On Thu, 2009-08-06 at 22:59 -0700, David Xiao wrote:
> > The V7 speculative prefetching will then probably apply to DMA coherency
> > issue in general, both kernel and user space DMAs. Could this be
> > addressed by inside the dma_unmap_sg/single() calling dma_cache_maint()
> > when the direction is DMA_FROM_DEVICE/DMA_BIDIRECTIONAL, to basically
> > invalidate the related cache lines in case any filled by prefetching?
> > Assuming dma_unmap_sg/single() is called after each DMA operation is
> > completed.
>
> Theoretically, with speculative prefetching on ARMv7 and the FROM_DEVICE
> case we need to invalidate the corresponding D-cache lines both before
> and after the DMA transfer, i.e. in both dma_map_sg and dma_unmap_sg,
> otherwise there is a risk of stale data in the cache.
>
The dma_map_sg() code is already calling dma_cache_maint() to invalidate
the cache lines in the DMA_FROM_DEVICE/DMA_BIDIRECTIONAL direction
cases. And the suggestion was to do something similar in dma_unmap_sg()
case to deal with the speculative prefetching on ARMv7, and Russel has
other postings talking about the details of this in terms of
feasibility/etc.
Furthermore, duplicate MMU mappings in the kernel bring more twists to
this problem as explained in this email chain as well, especially in the
case of DMA-coherent memory (dma_alloc_coherent()).
David
next prev parent reply other threads:[~2009-08-11 18:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 10:08 How to efficiently handle DMA and cache on ARMv7 ? (was "Is get_user_pages() enough to prevent pages from being swapped out ?") Laurent Pinchart
2009-08-06 11:46 ` Ben Dooks
2009-08-06 13:06 ` Laurent Pinchart
2009-08-06 18:46 ` David Xiao
2009-08-06 19:16 ` Chetan.Loke
2009-08-06 20:15 ` Jamie Lokier
2009-08-06 22:25 ` Russell King - ARM Linux
2009-08-07 5:59 ` David Xiao
2009-08-07 7:58 ` Laurent Pinchart
2009-08-07 8:10 ` Russell King - ARM Linux
2009-08-07 9:54 ` Jamie Lokier
2009-08-07 9:59 ` Russell King - ARM Linux
2009-08-07 12:07 ` Laurent Desnogues
2009-08-07 13:15 ` Robin Holt
2009-08-07 19:01 ` Russell King - ARM Linux
2009-08-07 20:11 ` Laurent Pinchart
2009-08-07 20:28 ` Russell King - ARM Linux
2009-08-07 22:25 ` David Xiao
2009-08-10 13:49 ` Laurent Pinchart
2009-08-07 8:08 ` Russell King - ARM Linux
2009-08-07 10:23 ` Jamie Lokier
2009-08-07 19:03 ` Russell King - ARM Linux
2009-08-11 9:31 ` Catalin Marinas
2009-08-11 18:23 ` David Xiao [this message]
2009-08-07 7:48 ` Laurent Pinchart
2009-08-25 12:53 ` Steven Walter
2009-08-25 22:02 ` David Xiao
2009-08-25 23:17 ` Laurent Pinchart
2009-08-26 17:22 ` David Xiao
2009-09-01 13:31 ` Russell King - ARM Linux
2009-09-01 18:08 ` David Xiao
2009-09-01 13:28 ` Russell King - ARM Linux
2009-09-01 13:43 ` Laurent Pinchart
2009-09-01 14:18 ` Russell King - ARM Linux
2009-09-01 16:53 ` Hugh Dickins
2009-09-02 15:10 ` Imre Deak
2009-09-03 7:31 ` Imre Deak
2009-09-03 8:36 ` Russell King - ARM Linux
2009-09-08 13:05 ` Steven Walter
2009-08-07 7:29 ` Laurent Pinchart
2009-08-07 8:12 ` Matthieu CASTET
2009-08-07 10:13 ` How to efficiently handle DMA and cache on ARMv7 ? (was " Is " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250014990.14439.4.camel@david-laptop \
--to=dxiao@broadcom.com \
--cc=ben-linux@fluff.org \
--cc=catalin.marinas@arm.com \
--cc=holt@sgi.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).