public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
	Alan Cox <alan@linux.intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: [PATCH 1/1] Power: fix suspend vt regression
Date: Tue, 11 Aug 2009 23:20:41 +0200	[thread overview]
Message-ID: <1250025641-5763-1-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <4A81E073.5080703@gmail.com>

vt_waitactive no longer accepts console parameter as console-1
since commit "vt: add an event interface". It expects console
number directly (as viewed by userspace -- counting from 1).

Fix a deadlock suspend regression by redefining adding one
to vt in vt_move_to_console.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
---
 drivers/char/vt_ioctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/vt_ioctl.c b/drivers/char/vt_ioctl.c
index 0fceb8f..e3d4d13 100644
--- a/drivers/char/vt_ioctl.c
+++ b/drivers/char/vt_ioctl.c
@@ -1554,7 +1554,7 @@ int vt_move_to_console(unsigned int vt, int alloc)
 		return -EIO;
 	}
 	release_console_sem();
-	if (vt_waitactive(vt)) {
+	if (vt_waitactive(vt + 1)) {
 		pr_debug("Suspend: Can't switch VCs.");
 		return -EINTR;
 	}
-- 
1.6.3.3


  reply	other threads:[~2009-08-11 21:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11  8:41 [PATCH 1/1] Power: fix suspend vt regression Jiri Slaby
2009-08-11 17:00 ` Greg KH
2009-08-11 21:19   ` Jiri Slaby
2009-08-11 21:20     ` Jiri Slaby [this message]
2009-08-31  9:47     ` suspend race -next regression [Was: Power: fix suspend vt regression] Jiri Slaby
2009-08-31 19:32       ` Rafael J. Wysocki
2009-09-04 11:49         ` suspend race -mm " Jiri Slaby
2009-09-04 22:30           ` Jiri Slaby
2009-09-04 22:36             ` Jiri Slaby
2009-09-05 12:39               ` [-mm] warning during suspend [was: suspend race -mm regression] Jiri Slaby
2009-09-05 14:41                 ` Xiao Guangrong
2009-09-10 20:57                   ` Andrew Morton
2009-09-11  0:00                     ` Suresh Siddha
2009-09-11  7:55                       ` Xiao Guangrong
2009-09-09 11:41           ` [PATCH 1/1] sched: fix cpu_down deadlock Jiri Slaby
2009-09-09 11:53             ` Peter Zijlstra
2009-09-09 12:23               ` Jiri Slaby
2009-09-09 12:37                 ` Peter Zijlstra
2009-09-09 13:46                 ` Oleg Nesterov
2009-09-11  6:09             ` Lai Jiangshan
2009-09-11  6:28               ` Jiri Slaby
2009-09-11  7:38                 ` Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250025641-5763-1-git-send-email-jirislaby@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox