From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, kjlu@umn.edu
Cc: pakki001@umn.edu, andrew@lunn.ch, vivien.didelot@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dsa: return error code upstream
Date: Thu, 27 Dec 2018 17:06:58 -0800 [thread overview]
Message-ID: <12500e65-ccc5-7545-4724-e328fa418576@gmail.com> (raw)
In-Reply-To: <20181227.162236.978596547594852209.davem@davemloft.net>
Le 12/27/18 à 4:22 PM, David Miller a écrit :
> From: Kangjie Lu <kjlu@umn.edu>
> Date: Tue, 25 Dec 2018 22:08:18 -0600
>
>> Both bcm_sf2_sw_indir_rw and mdiobus_write_nested could fail, so let's
>> return their error codes upstream.
>>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>
> Applied with Subject line adjusted as per Florian's feedback.
>
Thanks, technically bcm_sf2_sw_indir_rw() cannot fail and checking its
return value in the write (op == 0) case will always lead to returning 0
anyway. In case this ever changes in the future, we should be more
future proof with that change anyway.
--
Florian
next prev parent reply other threads:[~2018-12-28 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 4:08 [PATCH] dsa: return error code upstream Kangjie Lu
2018-12-26 17:31 ` Florian Fainelli
2018-12-28 0:22 ` David Miller
2018-12-28 1:06 ` Florian Fainelli [this message]
2018-12-28 1:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12500e65-ccc5-7545-4724-e328fa418576@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox