public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv
@ 2009-08-03  7:44 Huang Ying
  2009-08-05  9:45 ` Herbert Xu
  0 siblings, 1 reply; 11+ messages in thread
From: Huang Ying @ 2009-08-03  7:44 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-kernel, linux-crypto, Huang Ying

When doing "modeprobe tcrypt mode=10", the following error will show
in dmesg.

alg: skcipher: Failed to load transform for ctr(aes): -22
alg: skcipher: Failed to load transform for ctr(aes): -22
tcrypt: one or more tests failed!

Because ctr(aes) testing code will allocate ctr(aes) with geniv, but
defualt geniv mode may not work with ctr(aes). As that of rfc3686,
this is fixed via specifying geniv mode to "seqiv".

Signed-off-by: Huang Ying <ying.huang@intel.com>
---
 crypto/ctr.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/crypto/ctr.c
+++ b/crypto/ctr.c
@@ -219,6 +219,8 @@ static struct crypto_instance *crypto_ct
 	inst->alg.cra_blkcipher.encrypt = crypto_ctr_crypt;
 	inst->alg.cra_blkcipher.decrypt = crypto_ctr_crypt;
 
+	inst->alg.cra_blkcipher.geniv = "seqiv";
+
 out:
 	crypto_mod_put(alg);
 	return inst;

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2009-08-14 13:50 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-03  7:44 [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv Huang Ying
2009-08-05  9:45 ` Herbert Xu
2009-08-06  2:12   ` Huang Ying
2009-08-12  2:27     ` Huang Ying
2009-08-13  4:53       ` Herbert Xu
2009-08-13  7:39         ` Herbert Xu
2009-08-13 13:12           ` Herbert Xu
2009-08-14  1:01             ` Huang Ying
2009-08-14  1:05               ` Herbert Xu
2009-08-14 13:02             ` Herbert Xu
2009-08-14 13:47               ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox