From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] flex_array: fix flex_array_free_parts comment
Date: Mon, 17 Aug 2009 17:06:46 -0700 [thread overview]
Message-ID: <1250554007.10725.22008.camel@nimitz> (raw)
In-Reply-To: <alpine.DEB.2.00.0908171645270.30313@chino.kir.corp.google.com>
On Mon, 2009-08-17 at 16:46 -0700, David Rientjes wrote:
> flex_array_free_parts() does not take `src' or `element_nr' formals, so
> remove their respective comments.
>
> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> lib/flex_array.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/lib/flex_array.c b/lib/flex_array.c
> --- a/lib/flex_array.c
> +++ b/lib/flex_array.c
> @@ -122,9 +122,6 @@ static int fa_element_to_part_nr(struct flex_array *fa, int element_nr)
>
> /**
> * flex_array_free_parts - just free the second-level pages
> - * @src: address of data to copy into the array
> - * @element_nr: index of the position in which to insert
> - * the new element.
> *
> * This is to be used in cases where the base 'struct flex_array'
> * has been statically allocated and should not be free.
Looks great to me.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
-- Dave
next prev parent reply other threads:[~2009-08-18 0:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 23:46 [patch 1/3] flex_array: fix get function for elements in base starting at non-zero David Rientjes
2009-08-17 23:46 ` [patch 2/3] flex_array: fix flex_array_free_parts comment David Rientjes
2009-08-18 0:06 ` Dave Hansen [this message]
2009-08-17 23:46 ` [patch 3/3] flex_array: declare parts member to have incomplete type David Rientjes
2009-08-18 0:07 ` Dave Hansen
2009-08-18 0:19 ` [patch 1/3] flex_array: fix get function for elements in base starting at non-zero Dave Hansen
2009-08-18 0:49 ` David Rientjes
2009-08-18 1:46 ` Dave Hansen
2009-08-18 16:03 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250554007.10725.22008.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox