public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. R. Okajima" <hooanon05@yahoo.co.jp>
To: "Hans-Peter Jansen" <hpj@urpla.net>
Cc: Xianghua Xiao <xiaoxianghua@gmail.com>,
	Felix Fietkau <nbd@openwrt.org>,
	linux-kernel@vger.kernel.org, neilb@suse.de
Subject: Re: [PATCH 0/6 v7] overlay filesystem - request for inclusion
Date: Fri, 25 Mar 2011 00:24:26 +0900	[thread overview]
Message-ID: <12510.1300980266@jrobl> (raw)
In-Reply-To: <201103230013.41936.hpj@urpla.net>


(removed aufs-users ML since it is restricted to its members only)

"Hans-Peter Jansen":
> and aufs2: it's a minimalistic version of a layered filesystem, being=20
	:::

Thanks reminding us about aufs. :-)

As far as I know, overlayfs has some problems (minors?) similar to
UnionMount.
- for users, the inode number may change silently. eg. copy-up.
- hardlinks may break by copy-up.
- read(2) may get an obsoleted filedata (fstat(2) for metadata too).
- fcntl(F_SETLK) may be broken by copy-up.
- unnecessary copy-up may happen, for example mmap(MAP_PRIVATE) after
  open(O_RDWR).

And I noticed overlayfs adopts overriding credentials for copy-up.
Although I didn't read about credintials in detail yet, is it safe?
For example, during copy-up other thread in the same process may gain
the higher capabilities unexpectedly? Signal hander in the process too?

I just have read overlayfs once a long time ago, so I may be
misunderstanding.
But I have no objection to merge overlayfs into mainline.


Also I'd like to thank you Pete about mentioning the recent disaster in
Japan.


J. R. Okajima

  reply	other threads:[~2011-03-24 15:24 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 15:26 [PATCH 0/6 v7] overlay filesystem - request for inclusion Miklos Szeredi
2011-03-22 15:26 ` [PATCH 1/6 v7] vfs: add i_op->open() Miklos Szeredi
2011-03-22 17:18   ` Linus Torvalds
2011-03-22 18:12     ` Miklos Szeredi
2011-03-22 18:37       ` Linus Torvalds
2011-03-22 15:26 ` [PATCH 2/6 v7] vfs: export do_splice_direct() to modules Miklos Szeredi
2011-03-22 15:26 ` [PATCH 3/6 v7] vfs: introduce clone_private_mount() Miklos Szeredi
2011-03-22 15:26 ` [PATCH 4/6 v7] overlay filesystem prototype Miklos Szeredi
2011-03-22 17:30   ` Linus Torvalds
2011-03-22 18:15     ` Miklos Szeredi
2011-03-22 15:26 ` [PATCH 5/6 v7] overlayfs: add statfs support Miklos Szeredi
2011-03-22 15:26 ` [PATCH 6/6 v7] overlay: overlay filesystem documentation Miklos Szeredi
2011-03-22 17:36 ` [PATCH 0/6 v7] overlay filesystem - request for inclusion Linus Torvalds
2011-03-22 18:22   ` Felix Fietkau
2011-03-22 18:27     ` Linus Torvalds
2011-03-22 18:49     ` Xianghua Xiao
2011-03-22 23:13       ` Hans-Peter Jansen
2011-03-24 15:24         ` J. R. Okajima [this message]
2011-03-22 18:39   ` Al Viro
2011-03-22 18:48     ` Linus Torvalds
2011-03-22 18:58       ` Miklos Szeredi
2011-03-22 19:00         ` Al Viro
2011-03-22 19:43           ` Miklos Szeredi
2011-03-22 19:53             ` Al Viro
2011-03-22 20:06               ` Miklos Szeredi
2011-03-22 20:11                 ` Al Viro
2011-03-22 20:31                   ` Miklos Szeredi
2011-03-22 20:40                     ` Miklos Szeredi
2011-03-23 10:03                     ` Miklos Szeredi
2011-03-22 19:38         ` Al Viro
2011-03-22 19:56           ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12510.1300980266@jrobl \
    --to=hooanon05@yahoo.co.jp \
    --cc=hpj@urpla.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=neilb@suse.de \
    --cc=xiaoxianghua@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox