From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/profile: Fix profile_disable vs module_unload
Date: Tue, 25 Aug 2009 16:52:43 +0200 [thread overview]
Message-ID: <1251211963.7538.1164.camel@twins> (raw)
In-Reply-To: <1251197235.7538.1142.camel@twins>
On Tue, 2009-08-25 at 12:47 +0200, Peter Zijlstra wrote:
> On Tue, 2009-08-25 at 12:39 +0200, Ingo Molnar wrote:
>
> > > Do you really wish to burden every tracepoint user with the extra
> > > logic needed to deal with modules?
> >
> > Not necessarily - i'm just outlining why i think that the 'dont
> > allow subsystems to utilize tracepoint callbacks' is a restriction
> > we should not live with voluntarily.
>
> Well, unless someone has a bright idea that's what it comes down to.
OK, I still think modules probing their own tracepoints its stupid [*],
but what you could do is iterate the tracepoint's callback list and see
if it has a callback outside of the module code section and then fail
the unload.
[*] in the really utterly fundamentally wrong stupid class.
next prev parent reply other threads:[~2009-08-25 14:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 4:19 [PATCH] tracing/profile: Fix profile_disable vs module_unload Li Zefan
2009-08-24 6:01 ` Peter Zijlstra
2009-08-24 6:22 ` Li Zefan
2009-08-24 6:56 ` Peter Zijlstra
2009-08-24 9:24 ` Ingo Molnar
2009-08-24 9:27 ` Peter Zijlstra
2009-08-24 16:13 ` Steven Rostedt
2009-08-25 5:22 ` Li Zefan
2009-08-25 6:21 ` Peter Zijlstra
2009-08-25 6:33 ` Li Zefan
2009-08-25 6:40 ` Peter Zijlstra
2009-08-25 9:05 ` Ingo Molnar
2009-08-25 9:12 ` Peter Zijlstra
2009-08-25 10:22 ` Ingo Molnar
2009-08-25 10:32 ` Peter Zijlstra
2009-08-25 10:39 ` Ingo Molnar
2009-08-25 10:47 ` Peter Zijlstra
2009-08-25 14:52 ` Peter Zijlstra [this message]
2009-08-26 6:18 ` Li Zefan
2009-08-26 6:46 ` Peter Zijlstra
2009-08-26 6:52 ` Peter Zijlstra
2009-08-26 7:01 ` Peter Zijlstra
2009-08-26 7:10 ` Li Zefan
2009-08-26 7:26 ` Peter Zijlstra
2009-08-26 7:31 ` Li Zefan
2009-08-26 7:39 ` Peter Zijlstra
2009-08-26 7:44 ` Li Zefan
2009-08-26 14:37 ` Steven Rostedt
2009-08-26 16:46 ` Mathieu Desnoyers
2009-08-26 17:48 ` Steven Rostedt
2009-08-26 18:01 ` Mathieu Desnoyers
2009-08-26 18:17 ` Mathieu Desnoyers
2009-08-26 19:48 ` Steven Rostedt
2009-08-26 19:53 ` Mathieu Desnoyers
2009-08-26 21:21 ` Steven Rostedt
2009-08-26 22:29 ` Mathieu Desnoyers
2009-08-27 1:53 ` Li Zefan
2009-08-27 2:13 ` Steven Rostedt
2009-08-27 14:39 ` Mathieu Desnoyers
2009-08-27 14:56 ` Steven Rostedt
2009-08-27 15:11 ` Mathieu Desnoyers
2009-08-27 15:51 ` Steven Rostedt
2009-08-27 15:59 ` Mathieu Desnoyers
2009-08-27 16:03 ` Steven Rostedt
2009-08-27 6:25 ` Peter Zijlstra
2009-08-27 15:57 ` Steven Rostedt
2009-08-27 16:04 ` Peter Zijlstra
2009-08-27 16:18 ` Steven Rostedt
2009-08-27 1:01 ` Li Zefan
2009-08-26 19:14 ` Peter Zijlstra
2009-08-26 19:44 ` Mathieu Desnoyers
2009-09-13 15:02 ` [tip:tracing/core] tracing/profile: fix " tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251211963.7538.1164.camel@twins \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox