From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [RFC][PATCH -rt] sched: fully ignore RT tasks for CFS load-balancing
Date: Wed, 26 Aug 2009 16:44:35 +0200 [thread overview]
Message-ID: <1251297875.18584.5.camel@twins> (raw)
Since -rt runs IRQs and SoftIRQs as RT tasks and load-balancing is done
from softirq context, there is always at least one RT task (and very
likely multiple) running when we balance.
The current (and totally broken) interaction between RT tasks and CFS
load-balancing makes it so that we'll try to evacuate a significant
amount of tasks due to RT tasks being runnable.
Solve this in another broken way by not accounting RT tasks at all.
This will likely break another class of cases, but until we can properly
fix this, we might as well do this.
Chucked-on-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched_rt.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index adcbc68..385d31f 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -926,8 +926,6 @@ static void enqueue_task_rt(struct rq *rq, struct
task_struct *p, int wakeup)
if (!task_current(rq, p) && p->rt.nr_cpus_allowed > 1)
enqueue_pushable_task(rq, p);
-
- inc_cpu_load(rq, p->se.load.weight);
}
static void dequeue_task_rt(struct rq *rq, struct task_struct *p, int
sleep)
@@ -942,8 +940,6 @@ static void dequeue_task_rt(struct rq *rq, struct
task_struct *p, int sleep)
dequeue_rt_entity(rt_se);
dequeue_pushable_task(rq, p);
-
- dec_cpu_load(rq, p->se.load.weight);
}
/*
next reply other threads:[~2009-08-26 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 14:44 Peter Zijlstra [this message]
2009-08-26 18:52 ` [RFC][PATCH -rt] sched: fully ignore RT tasks for CFS load-balancing Darren Hart
2009-08-26 19:04 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251297875.18584.5.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox